From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEEABC77B7E for ; Thu, 1 Jun 2023 04:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230467AbjFAExH (ORCPT ); Thu, 1 Jun 2023 00:53:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230087AbjFAExG (ORCPT ); Thu, 1 Jun 2023 00:53:06 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CCC9129 for ; Wed, 31 May 2023 21:53:05 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 3A7A867373; Thu, 1 Jun 2023 06:53:02 +0200 (CEST) Date: Thu, 1 Jun 2023 06:53:02 +0200 From: Christoph Hellwig To: Qu Wenruo Cc: Johannes Thumshirn , Christoph Hellwig , Naohiro Aota , "linux-btrfs@vger.kernel.org" Subject: Re: new scrub code vs zoned file systems Message-ID: <20230601045302.GA22596@lst.de> References: <20230531125224.GB27468@lst.de> <546fad79-f436-c561-8b9b-0d9a7db09522@wdc.com> <20230531132032.GA30016@lst.de> <821003e3-b457-90ba-e733-8c2fdd0c3b3c@wdc.com> <20230531133038.GA30855@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Jun 01, 2023 at 06:25:59AM +0800, Qu Wenruo wrote: > To me, the problem can be solved in a much simpler way, if it's > dev-replace for zoned device, let's write the whole stripe to the target > device, and wait for it. > > For the btrfs_record_physical_zoned(), we can skip the OE things if > bbio::inode is NULL. > > Would the following change solves the problem? It can't, as we need to record the actually written location.