From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 911C9C77B7A for ; Thu, 1 Jun 2023 10:32:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232635AbjFAKcO (ORCPT ); Thu, 1 Jun 2023 06:32:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232167AbjFAKcI (ORCPT ); Thu, 1 Jun 2023 06:32:08 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3361E98 for ; Thu, 1 Jun 2023 03:32:06 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id DA8FC68AA6; Thu, 1 Jun 2023 12:22:17 +0200 (CEST) Date: Thu, 1 Jun 2023 12:22:17 +0200 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , Qu Wenruo , linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: fix dev-replace after the scrub rework Message-ID: <20230601102217.GA10149@lst.de> References: <0113e9e82b06106940e8ef7323fd4a9c01aa5afc.1685610531.git.wqu@suse.com> <20230601093747.GA6652@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Jun 01, 2023 at 06:12:12PM +0800, Qu Wenruo wrote: > Yes, the cleanup is also in my mind, but currently I prefer to do the > fix first in-place, then you can do the tide up after the more critical fix. There isn't really much of a difference in the diffstat between doing the consolidation and duplicating everything. So I don't think that's much of an argument.