Re: [PATCH v2] btrfs: make btrfs_destroy_delayed_refs() return void

[David Sterba <dsterba@suse.cz>]

On Fri, Jun 02, 2023 at 12:19:42PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> btrfs_destroy_delayed_refs() always returns 0 and its single caller does
> not check its return value, as it also returns void, and so does the
> callers' caller and so on. This is because we are in the transaction abort
> path, where we have no way to deal with errors (we are in a critical
> situation) and all cleanup of resources works in a best effort fashion.
> So make btrfs_destroy_delayed_refs() return void.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
> 
> V2: Make it explicit in the changelog that we are in the transaction
>     abort path and therefore have no way to deal with errors.
> 
>     V1 was part of a patchset that was merged except for this patch:
>     https://lore.kernel.org/linux-btrfs/cover.1685363099.git.fdmanana@suse.com/

Added to misc-next, my previous objections were meant for clarity and
the core of the error handling and return value passing lies in
unpin_extent_range(), not so significant for transaction cleanup.