Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: David Sterba <dsterba@suse.cz>, Chris Mason <clm@fb.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: allocate dummy ordereded_sums objects for nocsum I/O on zoned file systems
Date: Fri, 9 Jun 2023 21:18:34 +0200	[thread overview]
Message-ID: <20230609191834.GE12828@twin.jikos.cz> (raw)
In-Reply-To: <20230609045516.GA31024@lst.de>

On Fri, Jun 09, 2023 at 06:55:16AM +0200, Christoph Hellwig wrote:
> On Thu, Jun 08, 2023 at 05:40:15PM +0200, David Sterba wrote:
> > This patch is still in the devlopment queue so I don't want to do a
> > separate fix. Please send an incremental update that cleanly applies to
> > the patch.
> > 
> > There's a minor conflict in context of btrfs_finish_ordered_zoned in
> > zoned.c which only sets up the fs_info, so trivial to fix but the new
> > helper btrfs_alloc_dummy_sum() uses bbio->ordered which is not available
> > at this time and was added in a different series ("btrfs: add an
> > ordered_extent pointer to struct btrfs_bio").
> > 
> > Due to that there may be a cascading change needed in other patches in
> > misc-next but that should be fixable, the logic of adding bbio::ordered
> > is clear.
> 
> Ok.  Here is a stash of patches:
> 
>  1) incremental diff
>  2) complete replacement for that commit with the incremental
>     diff included
> 
> And then new version of the two later patches affected by the squashing:
> 
>  3) btrfs: defer splitting of ordered extents until I/O completion
>  4) btrfs: add an ordered_extent pointer to struct btrfs_bio
> 
> A git tree with all this is also available here:
> 
>     git://git.infradead.org/users/hch/misc.git btrfs-zoned-fixes

Thanks. I used the patches in the mail, I can't pull from infradead
(it.infradead.org[0: ...]: errno=Connection refused) so I at least
compared the committed versions against the patches. Misc-next updated
and pushed but I haven't tested it yet.

      reply	other threads:[~2023-06-09 19:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 12:14 fix nodatasum I/O for zone devices v2 Christoph Hellwig
2023-06-08 12:14 ` [PATCH] btrfs: allocate dummy ordereded_sums objects for nocsum I/O on zoned file systems Christoph Hellwig
2023-06-08 15:40   ` David Sterba
2023-06-09  4:55     ` Christoph Hellwig
2023-06-09 19:18       ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230609191834.GE12828@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox