From: David Sterba <dsterba@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
nborisov@suse.com, linux-btrfs@vger.kernel.org,
syzbot+ee90502d5c8fd1d0dd93@syzkaller.appspotmail.com
Subject: Re: [PATCH] btrfs: fix iomap_begin length for nocow writes
Date: Sat, 10 Jun 2023 00:17:42 +0200 [thread overview]
Message-ID: <20230609221742.GF12828@twin.jikos.cz> (raw)
In-Reply-To: <20230608091025.104716-1-hch@lst.de>
On Thu, Jun 08, 2023 at 11:10:25AM +0200, Christoph Hellwig wrote:
> can_nocow_extent can reduce the len passed in, which needs to be
> propagated to btrfs_dio_iomap_begin so that iomap does not submit
> more data then is mapped.
>
> This problems exists since the btrfs_get_blocks_direct helper was added
> in commit c5794e51784a ("btrfs: Factor out write portion of
> btrfs_get_blocks_direct"), but the ordered_extent splitting added in
> commit b73a6fd1b1ef ("btrfs: split partial dio bios before submit")
> added a WARN_ON that made a syzcaller test fail.
>
> Fixes: c5794e51784a ("btrfs: Factor out write portion of btrfs_get_blocks_direct")
> Reported-by: syzbot+ee90502d5c8fd1d0dd93@syzkaller.appspotmail.com
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Tested-by: syzbot+ee90502d5c8fd1d0dd93@syzkaller.appspotmail.com
Added to misc-next, thanks.
prev parent reply other threads:[~2023-06-09 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 9:10 [PATCH] btrfs: fix iomap_begin length for nocow writes Christoph Hellwig
2023-06-09 16:56 ` Filipe Manana
2023-06-09 22:17 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609221742.GF12828@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=syzbot+ee90502d5c8fd1d0dd93@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox