From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Chris Mason <clm@fb.com>,
linux-btrfs@vger.kernel.org, dsterba@suse.com,
josef@toxicpanda.com, hch@lst.de
Subject: Re: [PATCH RFC] Btrfs: only subtract from len_to_oe_boundary when it is tracking an extent
Date: Mon, 31 Jul 2023 09:02:51 +0200 [thread overview]
Message-ID: <20230731070251.GB31096@lst.de> (raw)
In-Reply-To: <e6557f41-9c3c-628a-958d-057582f8cab9@gmx.com>
On Mon, Jul 31, 2023 at 10:27:02AM +0800, Qu Wenruo wrote:
> Personally speaking, I think we'd better moving the ordered extent based
> split (only for zoned devices) to btrfs bio layer.
That goes completely counter the direction I've been working to. The
ordered extent is the "container" for writeback, so having a bio
that spawns them creates all kinds of problems. Thats's the reason
why we now have a bbio->ordered pointer now.
> Another concern is, how we could hit a bio which has a size larger than
> U32_MAX?
>
> The bio->bi_iter.size is only unsigned int, it should never exceed U32_MAX.
>
> It would help a lot if you can provide a backtrace of such unaligned bio.
That's indeed a bit weird.
next prev parent reply other threads:[~2023-07-31 7:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 19:02 [PATCH RFC] Btrfs: only subtract from len_to_oe_boundary when it is tracking an extent Chris Mason
2023-07-30 20:27 ` Sweet Tea Dorminy
2023-07-31 19:22 ` Chris Mason
2023-08-01 2:59 ` Sweet Tea Dorminy
2023-07-31 2:27 ` Qu Wenruo
2023-07-31 7:02 ` Christoph Hellwig [this message]
2023-07-31 18:10 ` Chris Mason
2023-08-01 0:58 ` Qu Wenruo
2023-07-31 7:00 ` Christoph Hellwig
2023-07-31 18:52 ` Chris Mason
2023-07-31 19:35 ` Christoph Hellwig
2023-07-31 21:05 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731070251.GB31096@lst.de \
--to=hch@lst.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox