From: Josef Bacik <josef@toxicpanda.com>
To: xiaoshoukui <xiaoshoukui@gmail.com>
Cc: dsterba@suse.cz, clm@fb.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
xiaoshoukui@ruijie.com.cn
Subject: Re: [PATCH] btrfs: fix race between balance and cancel/pause
Date: Wed, 9 Aug 2023 09:16:00 -0400 [thread overview]
Message-ID: <20230809131600.GB2515439@perftesting> (raw)
In-Reply-To: <20230808024748.20530-1-xiaoshoukui@gmail.com>
On Mon, Aug 07, 2023 at 10:47:48PM -0400, xiaoshoukui wrote:
> I think this patch does not fully fix the issue.
>
> This patch just fix assertion panic, but in the race situation, the ioctl pause
> request still returns an incorrect value 0 to the user which mislead the user the
> pause request finished successfully. In fact, the balance request has not been paused.
>
> Test results and analysis are as follows:
> https://lore.kernel.org/linux-btrfs/20230726030617.109018-1-xiaoshoukui@gmail.com/T/#me125d17fa59e9e671149cc76d410ced747f488b1
They're just two different issues. My patch is concerned with the panic, yours
is concerned with getting the correct return value out to the user.
Rebase your patch ontop of Sterba's tree with my fix and send it along, getting
an accurate errno out to the user is a reasonable goal. Thanks,
Josef
next prev parent reply other threads:[~2023-08-09 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 5:05 [PATCH] btrfs: fix race between balance and cancel/pause Josef Bacik
2023-06-29 15:01 ` David Sterba
2023-08-08 2:47 ` xiaoshoukui
2023-08-09 13:16 ` Josef Bacik [this message]
2023-08-10 5:45 ` xiaoshoukui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809131600.GB2515439@perftesting \
--to=josef@toxicpanda.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoshoukui@gmail.com \
--cc=xiaoshoukui@ruijie.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).