linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: tests/mkfs/005: use udevadm settle to avoid false alerts
Date: Wed, 9 Aug 2023 09:17:15 -0400	[thread overview]
Message-ID: <20230809131715.GC2515439@perftesting> (raw)
In-Reply-To: <688da51813559124605fca0f67c178095baca8d2.1691473890.git.wqu@suse.com>

On Tue, Aug 08, 2023 at 01:52:06PM +0800, Qu Wenruo wrote:
> [BUG]
> During my test runs of mkfs-tests, 005-long-device-name-for-ssd failed
> with the following error messages:
> 
>   ====== RUN CHECK dmsetup remove btrfs-test-with-very-long-name-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQPGc
>   device-mapper: remove ioctl on btrfs-test-with-very-long-name-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQPGc  failed: Device or resource busy
>   Command failed.
>   failed: dmsetup remove btrfs-test-with-very-long-name-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQPGc
>   test failed for case 005-long-device-name-for-ssd
> 
> [CAUSE]
> There seems to be a race between "btrfs inspect dump-super" and the
> dmsetup removal.
> 
> [FIX]
> Add a "udevadm settle" before removing the dm devices.
> 
> Also since we're here, use the same "udevadm settle" instead of the
> manual sleep to wait for the new dm device to showup.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

      reply	other threads:[~2023-08-09 13:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  5:52 [PATCH] btrfs-progs: tests/mkfs/005: use udevadm settle to avoid false alerts Qu Wenruo
2023-08-09 13:17 ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230809131715.GC2515439@perftesting \
    --to=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).