Re: [PATCH] btrfs-progs: tests/misc/030: do not require v1 cache for the test case

[Josef Bacik <josef@toxicpanda.com>]

On Tue, Aug 08, 2023 at 02:08:42PM +0800, Qu Wenruo wrote:
> [PROBLEM]
> Since we have migrated to default v2 cache, the test case
> misc/030-missing-device-image is no longer executed:
> 
>     [TEST/misc]   030-missing-device-image
>     [NOTRUN] unable to create v1 space cache
> 
> [CAUSE]
> The test case itself is trying its best to cover all paths, including
> the data extent read path.
> 
> Thus the test case is requiring v1 cache, as that's the only way to
> cover the data read path.
> 
> [FIX]
> Just remove the v1 space cache requirement, it's still better to run the
> test even it only exercises the metadata read path.
> 
> The good news is, after commit 3ff9d352576b ("btrfs-progs: use
> read_data_from_disk() to replace read_extent_from_disk() and replace
> read_extent_data()"), all data/metadata read paths are unified.
> They only differ in the verification part.
> 
> Thus even if we didn't fully exercise the data read path, we didn't lose
> much coverage anyway.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef