From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3F4C41513 for ; Wed, 9 Aug 2023 17:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232529AbjHIRTb (ORCPT ); Wed, 9 Aug 2023 13:19:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjHIRTa (ORCPT ); Wed, 9 Aug 2023 13:19:30 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C92911B6 for ; Wed, 9 Aug 2023 10:19:29 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-63d03d3cac6so298826d6.2 for ; Wed, 09 Aug 2023 10:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20221208.gappssmtp.com; s=20221208; t=1691601569; x=1692206369; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4YBEE6pa1JqtibEwuTLUswu8Sr+iHU/QjWeqfjBFoDM=; b=ZV99n1p12IM6O2ELZ49PhxekvruBA5827tHFjOZWWor+QL9d9x9F5e0IbhmXhXdioJ LgXe5FT3xqcArKxRemiD7/1xyS8HXE+sl855SaDSFzU39hW//TO7TO8bmY3RGTjDR/Xx 053IKfL/w2MuIV9g+Jjsbw+WVT3e5MEXJQFBYbEboTNWcjNO7rNkw4cZbCUDktj+B0gX /YnIpIJmBa4Zuq0tgc8qKe7G2fqsPsNv0wdNq8cf/Nzg0rCtloJzW5Q5dN8QQQ6fBMSZ cB7BJLs9/bpkg7RiDGWV4B3suLR+QIYeWA9G3gsHFU4DZag104xSQuDScOt54uZnAgiB SDzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691601569; x=1692206369; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4YBEE6pa1JqtibEwuTLUswu8Sr+iHU/QjWeqfjBFoDM=; b=d/9EQajnPJ+UYZoxtUaDB9+Fs7+Xf9BdgxjzkCyzTff/MihA+MWib1IQ4v3Y1Ej96d WWg1Lg3rZaaRH/b0VQz7fI3WlHPBYuOYvuXZ1APjCHVkpNTQ3Z8tVXEmb1lnntReYL5q IWQRT5y3HerQ2WsKvHB7rOd3c/L1oWPZYyhrCFW834S3o2rKbdG9poH/oMH9pTH7dtD+ m2/Ov7QmzUer+eqqeB3PFWlQi6iniGKtxI1BYoLvEJ3UtNliI8do7ZstqUBWVGpUqjkX VL3kAZFnpZRzG3IsDXTYjaMkCb2oMshErz/W2ciEzNXnBKnp0xv2SzahSnADXow13dPb SCdw== X-Gm-Message-State: AOJu0Yy5aR1mJuxF978fEvXVyLDq4wVRK11jOdF1SoErOkATtPBM/Vvd D92/p0V9rPj9rPviWZGezeCnjA== X-Google-Smtp-Source: AGHT+IHMmz1DPNKw2ZD2Y5jXQFtMAiKv8wFSYQUqkQSh75Gqj8mocqD8RzJt42qnd2mCqKzQ7d1Lww== X-Received: by 2002:a0c:b2c9:0:b0:626:290f:3e80 with SMTP id d9-20020a0cb2c9000000b00626290f3e80mr2921500qvf.50.1691601568979; Wed, 09 Aug 2023 10:19:28 -0700 (PDT) Received: from localhost (cpe-76-182-20-124.nc.res.rr.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id f17-20020a05620a12f100b00767f14f5856sm4156964qkl.117.2023.08.09.10.19.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 10:19:28 -0700 (PDT) Date: Wed, 9 Aug 2023 13:19:27 -0400 From: Josef Bacik To: Sweet Tea Dorminy Cc: Chris Mason , David Sterba , "Theodore Y . Ts'o" , Jaegeuk Kim , kernel-team@meta.com, linux-btrfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, Eric Biggers Subject: Re: [PATCH v6 1/8] fscrypt: move inline crypt decision to info setup Message-ID: <20230809171927.GB2516732@perftesting> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Aug 08, 2023 at 01:08:01PM -0400, Sweet Tea Dorminy wrote: > setup_file_encryption_key() is doing a lot of things at the moment -- > setting the crypt_info's inline encryption bit, finding and locking a > master key, and calling the functions to get the appropriate prepared > key for this info. Since setting the inline encryption bit has nothing > to do with finding the master key, it's easy and hopefully clearer to > select the encryption implementation in fscrypt_setup_encryption_info(), > the main fscrypt_info setup function, instead of in > setup_file_encryption_key() which will long-term only deal in setting > up the prepared key for the info. > > Signed-off-by: Sweet Tea Dorminy Reviewed-by: Josef Bacik Thanks, Josef