From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C7DDC04E69 for ; Wed, 9 Aug 2023 17:22:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232930AbjHIRWV (ORCPT ); Wed, 9 Aug 2023 13:22:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232912AbjHIRWU (ORCPT ); Wed, 9 Aug 2023 13:22:20 -0400 Received: from mail-vk1-xa36.google.com (mail-vk1-xa36.google.com [IPv6:2607:f8b0:4864:20::a36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E388210B for ; Wed, 9 Aug 2023 10:22:20 -0700 (PDT) Received: by mail-vk1-xa36.google.com with SMTP id 71dfb90a1353d-4871e54ee84so29077e0c.2 for ; Wed, 09 Aug 2023 10:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20221208.gappssmtp.com; s=20221208; t=1691601739; x=1692206539; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9LH5YqhPSZ5QpOregHu1NuMgeldEQ8bAarb691+Nqf0=; b=kYL2ipIdGKNz1u4+3H1vR/vk4QeEmo8wXc2xqx8n/PLR5nf2M+lFyRZsovtIX+OEXg hNxs9oAJvuyManDsY5M46Ti7xa1Ln+hiKPIDr/yvKIvTvrR+6G2EUPtYbgvM2/gg7e60 T7r+sOC7A59rxcvfau+p1FoP3jO/4+BTr0LA31JtjSeqJnLuWro6ErJrkVfd44RTfrsH lAPnG1rfjHrudiqgLMNHt1ST/TnrA1jEzURolfH6PvaINPKklAirHro5E3McCnQ8eNXw AmdyInPj7HkGZP210YAqA1eaPbiTjEHBE/bvc+xDvFHj3f3hge2dELXrNnMArDfcm2rf CedA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691601739; x=1692206539; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9LH5YqhPSZ5QpOregHu1NuMgeldEQ8bAarb691+Nqf0=; b=fz1N++wRNzCD4QJimDAlu/bPwqAsefoZUMQBMKpZl19jtrLz37qb+DnIVnCmt3luHD z5hXNoTAzclk6Y7kobmDdJMDj6hoEdJMFk514wp25xiBMeltdb/b/IE7Gez6K7XeDa3e 4ltsKQn6a1PNgMBuKEt/ovhC0rD3pgcVzxzYmNeYliXaF24rRnMCpIlaqVfa0XDjO2jh lYddbAp8XXDaFBv4QKqYmLzABlldEUJilmK9Vlod024pbuxQrgCxRwIHmEzIihjs4Yxs x7ZOH4B2tFbFoQOMnMjRNoVFyyfdfRJ6vBoQhRIx2mc7ZbS0kpa/k7OA1EIJdMqdYkvx AFzg== X-Gm-Message-State: AOJu0YxWK7Lb+0/oNi3XS/TL2vTqGkMb+mUFhJYx/4OhOH80gtNAsVH1 IbWF9py8nUmWJad74QCJQvbiRQ== X-Google-Smtp-Source: AGHT+IG2khZS7Tc4rkD6MRnzaAaIXX0Cynbzh5aEUkUwsjE6NmCpv7t08TOyEUYKdpCzIeHtjVhszw== X-Received: by 2002:a1f:4556:0:b0:47e:9bbb:103b with SMTP id s83-20020a1f4556000000b0047e9bbb103bmr81641vka.6.1691601739222; Wed, 09 Aug 2023 10:22:19 -0700 (PDT) Received: from localhost (cpe-76-182-20-124.nc.res.rr.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id q5-20020a0cf5c5000000b00626362f1bf1sm4548268qvm.63.2023.08.09.10.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 10:22:18 -0700 (PDT) Date: Wed, 9 Aug 2023 13:22:17 -0400 From: Josef Bacik To: Sweet Tea Dorminy Cc: Chris Mason , David Sterba , "Theodore Y . Ts'o" , Jaegeuk Kim , kernel-team@meta.com, linux-btrfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, Eric Biggers Subject: Re: [PATCH v6 3/8] fscrypt: split setup_per_mode_enc_key() Message-ID: <20230809172217.GC2516732@perftesting> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Aug 08, 2023 at 01:08:03PM -0400, Sweet Tea Dorminy wrote: > At present, setup_per_mode_enc_key() tries to find, within an array of > mode keys in the master key, an already prepared key, and if it doesn't > find a pre-prepared key, sets up a new one. This caching is not super > clear, at least to me, and splitting this function makes it clearer. > > Signed-off-by: Sweet Tea Dorminy Reviewed-by: Josef Bacik Thanks, Josef