From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] btrfs: remove v0 extent handling
Date: Fri, 11 Aug 2023 16:43:34 +0200 [thread overview]
Message-ID: <20230811144334.GO2420@twin.jikos.cz> (raw)
In-Reply-To: <2c8a0319e27ae48e0c0a6cedfd412382a705780e.1691751710.git.wqu@suse.com>
On Fri, Aug 11, 2023 at 07:02:11PM +0800, Qu Wenruo wrote:
> The v0 extent item has been deprecated for a long time, and we don't have
> any report from the community either.
>
> So it's time to remove the v0 extent specific error handling, and just
> treat them as regular extent tree corruption.
>
> This patch would remove the btrfs_print_v0_err() helper, and enhance the
> involved error handling to treat them just as any extent tree
> corruption.
We added the helper in 2018, so it's about 5 years ago, without any
reports so yeah let's remove it for good, thanks.
There are still remaining references to BTRFS_EXTENT_REF_V0_KEY in the
tracepoints and in ctree.h, at least the tracepiont should be deleted
but we may need to keep the ctree.h defintion documented so we don't
reuse the key number yet. I can fix that in the commit.
next prev parent reply other threads:[~2023-08-11 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 11:02 [PATCH v3] btrfs: remove v0 extent handling Qu Wenruo
2023-08-11 14:43 ` David Sterba [this message]
2023-08-11 23:08 ` Qu Wenruo
2023-08-12 19:17 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811144334.GO2420@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox