From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: scrub: avoid unnecessary extent tree search for striped profiles
Date: Fri, 18 Aug 2023 01:16:17 +0200 [thread overview]
Message-ID: <20230817231617.GY2420@twin.jikos.cz> (raw)
In-Reply-To: <a2c464a4-68cc-4e3d-a5f1-07f7727ef983@suse.com>
On Fri, Aug 18, 2023 at 07:08:56AM +0800, Qu Wenruo wrote:
> On 2023/8/17 19:47, David Sterba wrote:
> > On Tue, Aug 15, 2023 at 07:07:19PM +0800, Qu Wenruo wrote:
> >>
> >> Fixes: 8557635ed2b0 ("btrfs: scrub: introduce dedicated helper to scrub simple-stripe based range")
> >> Signed-off-by: Qu Wenruo <wqu@suse.com>
> >> ---
> >> Changelog:
> >> v2:
> >> - Fix a u64/u32 division not using the div_u64() helper
> >>
> >> - Slightly change the advancement of logical/physical for RAID0 and
> >> RAID56
> >> Now logical/physical is always increased first, this removes one
> >> if () branch.
> >>
> >> This patch is based on the scrub_testing branch (which is misc-next +
> >> scrub performance fixes).
> >>
> >> Thus there would be quite some conflicts for stable branches and would
> >> need manual backport.
> >
> > Added to misc-next, thanks.
>
> BTW, did you hit any compiling errors on 32bits systems?
>
> Some bots reported linkage error due to div_u64(), but I see the same
> div_u64() calls inside scrub.c thus I'm not sure what's really going on
> here.
I did a build test now and it's clean. The bots sometimes lag behind
either git trees or mailinglist.
prev parent reply other threads:[~2023-08-17 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 11:07 [PATCH v2] btrfs: scrub: avoid unnecessary extent tree search for striped profiles Qu Wenruo
2023-08-15 18:21 ` kernel test robot
2023-08-16 2:35 ` Qu Wenruo
2023-08-15 18:31 ` kernel test robot
2023-08-17 11:47 ` David Sterba
2023-08-17 23:08 ` Qu Wenruo
2023-08-17 23:16 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817231617.GY2420@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox