From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove pointless empty list check when reading delayed dir indexes
Date: Fri, 18 Aug 2023 18:16:08 +0200 [thread overview]
Message-ID: <20230818161608.GA2420@twin.jikos.cz> (raw)
In-Reply-To: <935cc2c19db41bde25d1ebb2e7d759737678ad51.1691938868.git.fdmanana@suse.com>
On Sun, Aug 13, 2023 at 04:03:28PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> At btrfs_readdir_delayed_dir_index(), called when reading a directory, we
> have this check for an empty list to return immediately, but it's not
> needed since list_for_each_entry_safe(), called immediately after, is
> prepared to deal with an empty list, it simply does nothing. So remove
> the empty list check.
>
> Besides shorter source code, it also slightly reduces the binary text
> size:
>
> Before this change:
>
> $ size fs/btrfs/btrfs.ko
> text data bss dec hex filename
> 1609408 167269 16864 1793541 1b5e05 fs/btrfs/btrfs.ko
>
> After this change:
>
> $ size fs/btrfs/btrfs.ko
> text data bss dec hex filename
> 1609392 167269 16864 1793525 1b5df5 fs/btrfs/btrfs.ko
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
That one has also been in misc-next for some time, thanks.
prev parent reply other threads:[~2023-08-18 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 15:03 [PATCH] btrfs: remove pointless empty list check when reading delayed dir indexes fdmanana
2023-08-18 16:16 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818161608.GA2420@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox