From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 2/3] btrfs-progs: clear root dirty when we update the root
Date: Wed, 23 Aug 2023 19:17:56 +0200 [thread overview]
Message-ID: <20230823171756.GG2420@twin.jikos.cz> (raw)
In-Reply-To: <5867c49c060d81c16fff55e20f62c0702ceae91f.1692800798.git.josef@toxicpanda.com>
On Wed, Aug 23, 2023 at 10:27:49AM -0400, Josef Bacik wrote:
> We don't currently use the bit to track whether or not the root is
> dirty, but when we sync ctree.c it uses this bit to determine if we
> should add the root to the dirty list. Clear this bit when we update
> the root so that the dirty tracking works properly when we sync ctree.c.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> kernel-shared/transaction.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel-shared/transaction.c b/kernel-shared/transaction.c
> index d30be5b5..49b435f6 100644
> --- a/kernel-shared/transaction.c
> +++ b/kernel-shared/transaction.c
> @@ -14,6 +14,7 @@
> * Boston, MA 021110-1307, USA.
> */
>
> +#include "kernel-lib/bitops.h"
> #include "kerncompat.h"
> #include "kernel-shared/disk-io.h"
> #include "kernel-shared/transaction.h"
The includes in all files have been reorganized so that they're grouped,
the kerncompat.h is first, then system includes and libraries, then
kernel-lib, kernel-shared, common/, cmds/, the rest.
next prev parent reply other threads:[~2023-08-23 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 14:27 [PATCH 0/3] btrfs-progs: a couple fixes Josef Bacik
2023-08-23 14:27 ` [PATCH 1/3] btrfs-progs: take a ref in the root locking code Josef Bacik
2023-08-23 14:27 ` [PATCH 2/3] btrfs-progs: clear root dirty when we update the root Josef Bacik
2023-08-23 17:17 ` David Sterba [this message]
2023-08-23 14:27 ` [PATCH 3/3] btrfs-progs: fix improper error handling in btrfs filesystem usage Josef Bacik
2023-08-23 17:18 ` [PATCH 0/3] btrfs-progs: a couple fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823171756.GG2420@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox