From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH] fstests: btrfs/213: fix the _not_run spell
Date: Thu, 24 Aug 2023 14:48:20 +0800 [thread overview]
Message-ID: <20230824064820.72147-1-wqu@suse.com> (raw)
The proper function is _notrun, not _not_run.
This can cause false alerts if the write speed is too fast or has some
cache causing the balance to finish eariler than expectation.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
tests/btrfs/213 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/btrfs/213 b/tests/btrfs/213
index 5666d9b9..6def4f6e 100755
--- a/tests/btrfs/213
+++ b/tests/btrfs/213
@@ -55,7 +55,7 @@ sleep $(($runtime / 4))
# any error about no balance currently running.
$BTRFS_UTIL_PROG balance cancel "$SCRATCH_MNT" 2>&1 | grep -iq 'not in progress'
if [ $? -eq 0 ]; then
- _not_run "balance finished before we could cancel it"
+ _notrun "balance finished before we could cancel it"
fi
# Now check if we can finish relocating metadata, which should finish very
--
2.41.0
next reply other threads:[~2023-08-24 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 6:48 Qu Wenruo [this message]
2023-08-24 7:40 ` [PATCH] fstests: btrfs/213: fix the _not_run spell Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824064820.72147-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox