Re: [PATCH 00/38] btrfs-progs: sync ctree.c into btrfs-progs

[David Sterba <dsterba@suse.cz>]

On Wed, Aug 23, 2023 at 10:32:26AM -0400, Josef Bacik wrote:
> Hello,
> 
> I started back up my extent tree v2 work and noticed not all my ctree.c sync
> patches made it in the last submission as I missed some comments.
> 
> This patchset is much larger than what was left, as I broke up the changes more
> discreetly.  In my original submission I had ignored some of the tree wide
> changes in favor of expediency, and had modified ctree.c more to match what we
> had in btrfs-progs.
> 
> This time I've updated everything that was different in ctree.c in the rest of
> btrfs-progs to make the actual sync'ing of ctree.c more straightforward.  I had
> to modify a few things in ctree.c, but they are very small and specific, no more
> updates of any of the global functions we depend on.
> 
> The downside is this patchset is massive.  The upside is the patches are small
> and self contained, with the obvious exception of the actual ctree.c sync.
> 
> This also will make subsequent sync'ing of other source files much easier, as
> I've changed a good deal of the very common helpers to match what exists in the
> kernel.
> 
> This passes all the tests.  There are a few behavior changes, but for the most
> part it's just updating helpers to match kernel definitions and moving code
> around.  Thanks,
> 
> Josef
> 
> Josef Bacik (38):
>   btrfs-progs: stop using add_root_to_dirty_list in check
>   btrfs-progs: remove useless add_root_to_dirty_list call in mkfs
>   btrfs-progs: remove add_root_to_dirty_list call when creating free
>     space tree
>   btrfs-progs: make add_root_to_dirty_list static and unexport it
>   btrfs-progs: pass btrfs_trans_handle through btrfs_clear_buffer_dirty
>   btrfs-progs: update read_node_slot to match the kernel definition
>   btrfs-progs: update btrfs_bin_search to match the kernel definition
>   btrfs-progs: update btrfs_set_item_key_safe to match kernel definition
>   btrfs-progs: update btrfs_print_leaf to match the kernel definition
>   btrfs-progs: update btrfs_truncate_item to match the kernel definition
>   btrfs-progs: update btrfs_extend_item to match the kernel definition
>   btrfs-progs: sync memcpy_extent_buffer from the kernel
>   btrfs-progs: drop btrfs_init_path
>   btrfs-progs: move btrfs_set_item_key_unsafe to check/
>   btrfs-progs: move btrfs_record_file_extent and code into a new file
>   btrfs-progs: make a local copy of btrfs_next_sibling_block in
>     print-tree.c
>   btrfs-progs: don't set the ->commit_root in btrfs_create_tree
>   btrfs-progs: remove btrfs_create_root
>   btrfs-progs: move btrfs_uuid_tree_add into mkfs/main.c
>   btrfs-progs: make btrfs_del_ptr a void
>   btrfs-progs: replace blocksize with parent argument for
>     btrfs_alloc_tree_block
>   btrfs-progs: use path->search_for_extension
>   btrfs-progs: init new tree blocks in btrfs_alloc_tree_block
>   btrfs-progs: add dwarves to the package list for ci
>   btrfs-progs: add kerncompat helpers for ctree.c sync
>   btrfs-progs: add trans_lock to fs_info
>   btrfs-progs: add commit_root_sem to btrfs_fs_info
>   btrfs-progs: update btrfs_cow_block to match the in-kernel definition
>   btrfs-progs: update btrfs_insert_empty_items to match the kernel
>   btrfs-progs: update btrfs_insert_empty_item to match the kernel
>   btrfs-progs: update btrfs_del_ptr to match the kernel
>   btrfs-progs: update btrfs_insert_item to match the kernel
>   btrfs-progs: update btrfs_leaf_free_space to match the kernel
>   btrfs-progs: use btrfs_tree_parent_check for btrfs_read_extent_buffer
>   btrfs-progs: update read_tree_block to take a btrfs_parent_tree_check
>   btrfs-progs: inline btrfs_name_hash and btrfs_extref_hash
>   btrfs-progs: update btrfs_split_item to match the in-kernel definition

1-37 applied, with some minor fixups, thanks. This change granularity is
good.