From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 12/12] btrfs: remove extraneous includes from ctree.h
Date: Tue, 5 Sep 2023 15:44:06 +0200 [thread overview]
Message-ID: <20230905134406.GA14420@twin.jikos.cz> (raw)
In-Reply-To: <15d63abd06cb64b7edc83d033e65ca00a2bae3ba.1692994620.git.josef@toxicpanda.com>
On Fri, Aug 25, 2023 at 04:19:30PM -0400, Josef Bacik wrote:
> We don't need any of these includes in the ctree.h header file for the
> header file itself, remove them to clean up ctree.h a little bit.
While the include reduction is nice, we still don't have the includes
for everything ctree.h uses, e.g. spinlock_t, mutex, pid_t, rb_tree and
maybe more. It's not critical as long as it compiles and we have the
includes entangled too much so incremental updates work better. The tool
include-what-you-use can print the recommendeations for adding and
removing includes but it can get confused by direct includes by command
line -include. I did a pass for btrfs-progs, desiable for kernel too.
next prev parent reply other threads:[~2023-09-05 16:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 20:19 [PATCH v2 00/12] btrfs: ctree.[ch] cleanups Josef Bacik
2023-08-25 20:19 ` [PATCH v2 01/12] btrfs: move btrfs_crc32c_final into free-space-cache.c Josef Bacik
2023-08-25 20:19 ` [PATCH v2 02/12] btrfs: remove btrfs_crc32c wrapper Josef Bacik
2023-08-25 20:19 ` [PATCH v2 03/12] btrfs: move btrfs_extref_hash into inode-item.h Josef Bacik
2023-08-25 20:19 ` [PATCH v2 04/12] btrfs: move btrfs_name_hash to dir-item.h Josef Bacik
2023-08-25 20:19 ` [PATCH v2 05/12] btrfs: include asm/unaligned.h in accessors.h Josef Bacik
2023-08-25 20:19 ` [PATCH v2 06/12] btrfs: include linux/crc32c in dir-item and inode-item Josef Bacik
2023-08-25 20:19 ` [PATCH v2 07/12] btrfs: include linux/iomap.h in file.c Josef Bacik
2023-08-25 20:19 ` [PATCH v2 08/12] btrfs: add fscrypt related dependencies to respective headers Josef Bacik
2023-08-25 20:19 ` [PATCH v2 09/12] btrfs: add btrfs_delayed_ref_head declaration to extent-tree.h Josef Bacik
2023-08-25 20:19 ` [PATCH v2 10/12] btrfs: include trace header in where necessary Josef Bacik
2023-08-25 20:19 ` [PATCH v2 11/12] btrfs: include linux/security.h in super.c Josef Bacik
2023-08-25 20:19 ` [PATCH v2 12/12] btrfs: remove extraneous includes from ctree.h Josef Bacik
2023-09-05 13:44 ` David Sterba [this message]
2023-08-28 16:25 ` [PATCH v2 00/12] btrfs: ctree.[ch] cleanups Johannes Thumshirn
2023-09-05 13:45 ` David Sterba
2023-09-05 14:38 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905134406.GA14420@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).