From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88AEDCA0EC6 for ; Mon, 11 Sep 2023 22:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355873AbjIKWCP (ORCPT ); Mon, 11 Sep 2023 18:02:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243953AbjIKSbc (ORCPT ); Mon, 11 Sep 2023 14:31:32 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49C61198; Mon, 11 Sep 2023 11:31:27 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E2EA83200912; Mon, 11 Sep 2023 14:31:23 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 11 Sep 2023 14:31:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bur.io; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1694457083; x=1694543483; bh=Ec MFYvhUrMnasEqJwEyJPej38pS4lZZ3N7GELDh7r38=; b=nMcci+o/59MCemrXW5 8dcZVnfHs5GPM/Dq4tcYijrGi7fvsxjxnWFulAC+EaeWcnl3ZwVgO7HOZ8kx268J v3J5+OGvDxhy13nngEYTNboVIzpeafHZ+HFPftahw0sACD266c3kbfX4Vc2cXwtR guQMSJV37NO13UnGXSzRuLPMURW4gK49vti+MfkO9Rw2Fm5cp2ev8btsP22PKoGw 43U7F1WShYKCs4fNKvClrt+NYXWBRiBLZKbbwVGTTUdr1tLhbPHnP+KJTDd0PJA0 h/WrFRkJQTs+2bIqEzNrp7S+Ph8Vx7MPWYS9p5+mBn6ZbIkzKk7Ln8wbEQMEXsxF jjtA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1694457083; x=1694543483; bh=EcMFYvhUrMnas EqJwEyJPej38pS4lZZ3N7GELDh7r38=; b=vsmmCu4Nv39Ay3NHLb3N2iQhwjdzZ BHtUv5ei4e6U18ndUC855+9I8tupLZfAvGOrKojYzPcKvyGm9rbUYicMFehpzWi6 VTWygoxtHLzqZFVbBngs5RmEKrdpeqAD/4wJn9t52HZk9DZFotfluoEsFGiBsQMF 7Vi7rZS4i2Ot48+hvYOwK6fBAUSsAr/KsMzwvwYKzJATlEcKEyx8fWZODYQX7pDW WV0hMtqoZKrnPzL6zpxcYHvN7NbX97pcPiDQdqSBq50iF+L/VAP3MV/UnDl4PlhH X1dQF2fxUGBkGuLXAOee0jgFpplCm4rWaxLFo1pnmic4vsJjTGgm+yXmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeigedguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhr ihhsuceuuhhrkhhovhcuoegsohhrihhssegsuhhrrdhioheqnecuggftrfgrthhtvghrnh epkedvkeffjeellefhveehvdejudfhjedthfdvveeiieeiudfguefgtdejgfefleejnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghorhhish essghurhdrihho X-ME-Proxy: Feedback-ID: i083147f8:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Sep 2023 14:31:22 -0400 (EDT) Date: Mon, 11 Sep 2023 11:32:19 -0700 From: Boris Burkov To: Anand Jain Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH] fstests: btrfs/185 update for single device pseudo device-scan Message-ID: <20230911183219.GA1770132@zen> References: <7558eed09a89d25fbd8083d45078cfe2e9601f45.1694017375.git.anand.jain@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7558eed09a89d25fbd8083d45078cfe2e9601f45.1694017375.git.anand.jain@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Sep 07, 2023 at 12:24:43AM +0800, Anand Jain wrote: > As we are obliterating the need for the device scan for the single device, > which will return success if the basic superblock verification passes, > even for the duplicate device of the mounted filesystem, drop the check > for the return code in this testcase and continue to verify if the device > path of the mounted filesystem remains unaltered after the scan. > > Also, if the test fails, it leaves the local non-standard mount point > remained mounted, leading to further test cases failing. Call unmount > in _cleanup(). This was also affecting my setup, thanks for the fix! > > Signed-off-by: Anand Jain > --- > tests/btrfs/185 | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/btrfs/185 b/tests/btrfs/185 > index ba0200617e69..c7b8d2d46951 100755 > --- a/tests/btrfs/185 > +++ b/tests/btrfs/185 > @@ -15,6 +15,7 @@ mnt=$TEST_DIR/$seq.mnt > # Override the default cleanup function. > _cleanup() > { > + $UMOUNT_PROG $mnt > /dev/null 2>&1 Do you mean to umount before calling rm -rf on it? That seems.. risky. > rm -rf $mnt > /dev/null 2>&1 > cd / > rm -f $tmp.* > @@ -51,9 +52,9 @@ for sb_bytenr in 65536 67108864; do > echo ..:$? >> $seqres.full > done > > -# Original device is mounted, scan of its clone should fail > +# Original device is mounted, scan of its clone must not alter the > +# filesystem device path > $BTRFS_UTIL_PROG device scan $device_2 >> $seqres.full 2>&1 > -[[ $? != 1 ]] && _fail "cloned device scan should fail" > > [[ $(findmnt $mnt | grep -v TARGET | $AWK_PROG '{print $2}') != $device_1 ]] && \ > _fail "mounted device changed" > -- > 2.39.3 >