* [PATCH] btrfs: remove stale comment from btrfs_free_extent()
@ 2023-09-15 15:02 fdmanana
2023-09-15 15:26 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: fdmanana @ 2023-09-15 15:02 UTC (permalink / raw)
To: linux-btrfs
From: Filipe Manana <fdmanana@suse.com>
A comment at btrfs_free_extent() mentions the call to btrfs_pin_extent()
unlocks the pinned mutex, however that mutex is long gone, it was removed
in 2009 by commit 04018de5d41e ("Btrfs: kill the pinned_mutex"). So just
delete the comment.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
fs/btrfs/extent-tree.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 6ef7319bb7ef..1701aadbfea3 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -3375,7 +3375,6 @@ int btrfs_free_extent(struct btrfs_trans_handle *trans, struct btrfs_ref *ref)
ref->tree_ref.owning_root == BTRFS_TREE_LOG_OBJECTID) ||
(ref->type == BTRFS_REF_DATA &&
ref->data_ref.owning_root == BTRFS_TREE_LOG_OBJECTID)) {
- /* unlocks the pinned mutex */
btrfs_pin_extent(trans, ref->bytenr, ref->len, 1);
ret = 0;
} else if (ref->type == BTRFS_REF_METADATA) {
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: remove stale comment from btrfs_free_extent()
2023-09-15 15:02 [PATCH] btrfs: remove stale comment from btrfs_free_extent() fdmanana
@ 2023-09-15 15:26 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2023-09-15 15:26 UTC (permalink / raw)
To: fdmanana; +Cc: linux-btrfs
On Fri, Sep 15, 2023 at 04:02:56PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> A comment at btrfs_free_extent() mentions the call to btrfs_pin_extent()
> unlocks the pinned mutex, however that mutex is long gone, it was removed
> in 2009 by commit 04018de5d41e ("Btrfs: kill the pinned_mutex"). So just
> delete the comment.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-15 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-15 15:02 [PATCH] btrfs: remove stale comment from btrfs_free_extent() fdmanana
2023-09-15 15:26 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).