From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Alexander Potapenko <glider@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
David Ahern <dsahern@kernel.org>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Simon Horman <simon.horman@corigine.com>,
netdev@vger.kernel.org, linux-btrfs@vger.kernel.org,
dm-devel@redhat.com, ntfs3@lists.linux.dev,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 05/13] s390/cio: rename bitmap_size() -> idset_bitmap_size()
Date: Mon, 16 Oct 2023 18:52:39 +0200 [thread overview]
Message-ID: <20231016165247.14212-6-aleksander.lobakin@intel.com> (raw)
In-Reply-To: <20231016165247.14212-1-aleksander.lobakin@intel.com>
bitmap_size() is a pretty generic name and one may want to use it for
a generic bitmap API function. At the same time, its logic is not
"generic", i.e. it's not just `nbits -> size of bitmap in bytes`
converter as it would be expected from its name.
Add the prefix 'idset_' used throughout the file where the function
resides.
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
---
idset_new() really wants its vmalloc() + memset() pair to be replaced
with vzalloc().
---
drivers/s390/cio/idset.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/s390/cio/idset.c b/drivers/s390/cio/idset.c
index 45f9c0736be4..0a1105a483bf 100644
--- a/drivers/s390/cio/idset.c
+++ b/drivers/s390/cio/idset.c
@@ -16,7 +16,7 @@ struct idset {
unsigned long bitmap[];
};
-static inline unsigned long bitmap_size(int num_ssid, int num_id)
+static inline unsigned long idset_bitmap_size(int num_ssid, int num_id)
{
return BITS_TO_LONGS(num_ssid * num_id) * sizeof(unsigned long);
}
@@ -25,11 +25,12 @@ static struct idset *idset_new(int num_ssid, int num_id)
{
struct idset *set;
- set = vmalloc(sizeof(struct idset) + bitmap_size(num_ssid, num_id));
+ set = vmalloc(sizeof(struct idset) +
+ idset_bitmap_size(num_ssid, num_id));
if (set) {
set->num_ssid = num_ssid;
set->num_id = num_id;
- memset(set->bitmap, 0, bitmap_size(num_ssid, num_id));
+ memset(set->bitmap, 0, idset_bitmap_size(num_ssid, num_id));
}
return set;
}
@@ -41,7 +42,8 @@ void idset_free(struct idset *set)
void idset_fill(struct idset *set)
{
- memset(set->bitmap, 0xff, bitmap_size(set->num_ssid, set->num_id));
+ memset(set->bitmap, 0xff,
+ idset_bitmap_size(set->num_ssid, set->num_id));
}
static inline void idset_add(struct idset *set, int ssid, int id)
--
2.41.0
next prev parent reply other threads:[~2023-10-16 17:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 16:52 [PATCH v2 00/13] ip_tunnel: convert __be16 tunnel flags to bitmaps Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 01/13] bitops: add missing prototype check Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 02/13] bitops: make BYTES_TO_BITS() treewide-available Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 03/13] bitops: let the compiler optimize {__,}assign_bit() Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 04/13] linkmode: convert linkmode_{test,set,clear,mod}_bit() to macros Alexander Lobakin
2023-10-19 0:27 ` Jakub Kicinski
2023-10-16 16:52 ` Alexander Lobakin [this message]
2023-10-16 16:52 ` [PATCH v2 06/13] fs/ntfs3: add prefix to bitmap_size() and use BITS_TO_U64() Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 07/13] btrfs: rename bitmap_set_bits() -> btrfs_bitmap_set_bits() Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 08/13] bitmap: introduce generic optimized bitmap_size() Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 09/13] bitmap: make bitmap_{get,set}_value8() use bitmap_{read,write}() Alexander Lobakin
2023-10-16 17:48 ` Yury Norov
2023-10-16 16:52 ` [PATCH v2 10/13] ip_tunnel: use a separate struct to store tunnel params in the kernel Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 11/13] ip_tunnel: convert __be16 tunnel flags to bitmaps Alexander Lobakin
2023-10-19 0:27 ` Jakub Kicinski
2023-10-20 7:41 ` Alexander Potapenko
2023-10-20 12:30 ` Yury Norov
2023-11-02 11:48 ` Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 12/13] lib/bitmap: add compile-time test for __assign_bit() optimization Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 13/13] lib/bitmap: add tests for IP tunnel flags conversion helpers Alexander Lobakin
2023-10-16 17:54 ` [PATCH v2 00/13] ip_tunnel: convert __be16 tunnel flags to bitmaps Yury Norov
2023-10-20 12:46 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016165247.14212-6-aleksander.lobakin@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dm-devel@redhat.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=kuba@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=przemyslaw.kitszel@intel.com \
--cc=simon.horman@corigine.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).