From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Alexander Potapenko <glider@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
David Ahern <dsahern@kernel.org>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Simon Horman <simon.horman@corigine.com>,
netdev@vger.kernel.org, linux-btrfs@vger.kernel.org,
dm-devel@redhat.com, ntfs3@lists.linux.dev,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
David Sterba <dsterba@suse.com>
Subject: [PATCH v2 07/13] btrfs: rename bitmap_set_bits() -> btrfs_bitmap_set_bits()
Date: Mon, 16 Oct 2023 18:52:41 +0200 [thread overview]
Message-ID: <20231016165247.14212-8-aleksander.lobakin@intel.com> (raw)
In-Reply-To: <20231016165247.14212-1-aleksander.lobakin@intel.com>
bitmap_set_bits() does not start with the FS' prefix and may collide
with a new generic helper one day. It operates with the FS-specific
types, so there's no change those two could do the same thing.
Just add the prefix to exclude such possible conflict.
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Acked-by: David Sterba <dsterba@suse.com>
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
---
fs/btrfs/free-space-cache.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index 27fad70451aa..94249b5ee447 100644
--- a/fs/btrfs/free-space-cache.c
+++ b/fs/btrfs/free-space-cache.c
@@ -1909,9 +1909,9 @@ static inline void bitmap_clear_bits(struct btrfs_free_space_ctl *ctl,
ctl->free_space -= bytes;
}
-static void bitmap_set_bits(struct btrfs_free_space_ctl *ctl,
- struct btrfs_free_space *info, u64 offset,
- u64 bytes)
+static void btrfs_bitmap_set_bits(struct btrfs_free_space_ctl *ctl,
+ struct btrfs_free_space *info, u64 offset,
+ u64 bytes)
{
unsigned long start, count, end;
int extent_delta = 1;
@@ -2247,7 +2247,7 @@ static u64 add_bytes_to_bitmap(struct btrfs_free_space_ctl *ctl,
bytes_to_set = min(end - offset, bytes);
- bitmap_set_bits(ctl, info, offset, bytes_to_set);
+ btrfs_bitmap_set_bits(ctl, info, offset, bytes_to_set);
return bytes_to_set;
--
2.41.0
next prev parent reply other threads:[~2023-10-16 16:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 16:52 [PATCH v2 00/13] ip_tunnel: convert __be16 tunnel flags to bitmaps Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 01/13] bitops: add missing prototype check Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 02/13] bitops: make BYTES_TO_BITS() treewide-available Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 03/13] bitops: let the compiler optimize {__,}assign_bit() Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 04/13] linkmode: convert linkmode_{test,set,clear,mod}_bit() to macros Alexander Lobakin
2023-10-19 0:27 ` Jakub Kicinski
2023-10-16 16:52 ` [PATCH v2 05/13] s390/cio: rename bitmap_size() -> idset_bitmap_size() Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 06/13] fs/ntfs3: add prefix to bitmap_size() and use BITS_TO_U64() Alexander Lobakin
2023-10-16 16:52 ` Alexander Lobakin [this message]
2023-10-16 16:52 ` [PATCH v2 08/13] bitmap: introduce generic optimized bitmap_size() Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 09/13] bitmap: make bitmap_{get,set}_value8() use bitmap_{read,write}() Alexander Lobakin
2023-10-16 17:48 ` Yury Norov
2023-10-16 16:52 ` [PATCH v2 10/13] ip_tunnel: use a separate struct to store tunnel params in the kernel Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 11/13] ip_tunnel: convert __be16 tunnel flags to bitmaps Alexander Lobakin
2023-10-19 0:27 ` Jakub Kicinski
2023-10-20 7:41 ` Alexander Potapenko
2023-10-20 12:30 ` Yury Norov
2023-11-02 11:48 ` Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 12/13] lib/bitmap: add compile-time test for __assign_bit() optimization Alexander Lobakin
2023-10-16 16:52 ` [PATCH v2 13/13] lib/bitmap: add tests for IP tunnel flags conversion helpers Alexander Lobakin
2023-10-16 17:54 ` [PATCH v2 00/13] ip_tunnel: convert __be16 tunnel flags to bitmaps Yury Norov
2023-10-20 12:46 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016165247.14212-8-aleksander.lobakin@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dm-devel@redhat.com \
--cc=dsahern@kernel.org \
--cc=dsterba@suse.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=kuba@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=netdev@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=przemyslaw.kitszel@intel.com \
--cc=simon.horman@corigine.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).