From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25288CDB483 for ; Tue, 17 Oct 2023 05:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234032AbjJQFXP (ORCPT ); Tue, 17 Oct 2023 01:23:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232701AbjJQFXN (ORCPT ); Tue, 17 Oct 2023 01:23:13 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF86EA4; Mon, 16 Oct 2023 22:23:12 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D8E5C433C7; Tue, 17 Oct 2023 05:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697520192; bh=8a9rutlwqfj5Q4pk1Kspv2LSYZQ6AbZdXsVPFocNvz4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jfhD4QD0UM4TUcFKBSg6e0WWz3CxX8rnwJZyLndz514KYAlz2SL3wQ21Wq2kAtB6r DoAiBcy9SHr+uqv/T22p5/V9UwLfLCrbRfXZKUYeoaQC9bFqsHEn0O8Q/ItXjAeiMk WYVG6Aysaihf4feN6d5sN5cqoquwZpKcjUdnXny/ZR14yFgX2KXuurZyx5GNyOIrWz gjubEAGbdExLN568JEUbBS3vq+XlyMmqry8czJlHh3LHRL1LV/dbeaQ+kvYfLG8Gac oMGhq3KxV4LRfpuJUVgtoUB5oIUlUmcn3QgjfxXPsvduFZ7yepAtjOk33kbK7SFvE7 HY+3+a6n/qrNg== Date: Mon, 16 Oct 2023 22:23:10 -0700 From: Eric Biggers To: Josef Bacik Cc: fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 12/12] fstest: add a fsstress+fscrypt test Message-ID: <20231017052310.GF1907@sol.localdomain> References: <936037a6c2bcf5553145862c5358e175621983b0.1696969376.git.josef@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <936037a6c2bcf5553145862c5358e175621983b0.1696969376.git.josef@toxicpanda.com> Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Oct 10, 2023 at 04:26:05PM -0400, Josef Bacik wrote: > I noticed we don't run fsstress with fscrypt in any of our tests, and > this was helpful in uncovering a couple of symlink related corner cases > for the btrfs support work. Add a basic test that creates a encrypted > directory and runs fsstress in that directory. > > Signed-off-by: Josef Bacik > --- > tests/generic/736 | 38 ++++++++++++++++++++++++++++++++++++++ > tests/generic/736.out | 3 +++ > 2 files changed, 41 insertions(+) > create mode 100644 tests/generic/736 > create mode 100644 tests/generic/736.out This might be worth adding, but the way this sort of thing is tested on other filesystems is through implementing the test_dummy_encryption mount option and then doing a full run of xfstests with test_dummy_encryption enabled. That's more comprehensive than just running fsstress. - Eric