From: David Sterba <dsterba@suse.cz>
To: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+d66de4cbf532749df35f@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] btrfs: ref-verify: fix memory leaks
Date: Tue, 21 Nov 2023 14:03:15 +0100 [thread overview]
Message-ID: <20231121130315.GP11264@twin.jikos.cz> (raw)
In-Reply-To: <20231118091012.14818-1-bragathemanick0908@gmail.com>
On Sat, Nov 18, 2023 at 02:40:12PM +0530, Bragatheswaran Manickavel wrote:
> In btrfs_ref_tree_mod(), when !parent 're' was allocated
> through kmalloc(). In the following code, if an error occurs,
> the execution will be redirected to 'out' or 'out_unlock' and
> the function will be exited. However, on some of the paths,
> 're' are not deallocated and may lead to memory leaks.
>
> For example : lookup_block_entry() for 'be' returns null, the
> out label will be invoked. During that flow ref and ra was
> freed but not re, which can potentially lead to memleak
>
> Reported-and-tested-by: syzbot+d66de4cbf532749df35f@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=d66de4cbf532749df35f
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2023-11-21 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 9:10 [PATCH v2] btrfs: ref-verify: fix memory leaks Bragatheswaran Manickavel
2023-11-21 13:03 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231121130315.GP11264@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bragathemanick0908@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+d66de4cbf532749df35f@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox