public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/5] Reduce size of extent_io_tree, remove fs_info
Date: Tue, 21 Nov 2023 09:19:58 -0500	[thread overview]
Message-ID: <20231121141958.GB1667963@perftesting> (raw)
In-Reply-To: <cover.1700572232.git.dsterba@suse.com>

On Tue, Nov 21, 2023 at 02:20:12PM +0100, David Sterba wrote:
> We have the fs_info pointer in extent_io_tree for the trace points as
> the inode is not always set. This is a bit wasteful and extent_io_tree
> is also embedded in other structures. The tree owner can be used to
> determine if the inode is expected to be non-NULL, otherwise we can
> store the fs_info pointer.
> 
> I tried to do it in the cleanest way, union and access wrappers, it's
> IMO worth the space savings:
> 
> - btrfs_inode		1104 -> 1088
> - btrfs_device		 520 ->  512
> - btrfs_root		1360 -> 1344
> - btrfs_transaction	 456 ->  440
> - btrfs_fs_info		3600 -> 3592
> - reloc_control		1520 -> 1512
> 
> The btrfs_inode structure is getting closer to the 1024 size where it
> would pack better in the slab pages.
>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef 

      parent reply	other threads:[~2023-11-21 14:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21 13:20 [PATCH 0/5] Reduce size of extent_io_tree, remove fs_info David Sterba
2023-11-21 13:20 ` [PATCH 1/5] btrfs: move lockdep class setting out of extent_io_tree_init David Sterba
2023-11-21 13:20 ` [PATCH 2/5] btrfs: drop error message in extent_io_tree insert_state() David Sterba
2023-11-21 13:20 ` [PATCH 3/5] btrfs: constify fs_info parameter in __btrfs_panic() David Sterba
2023-11-21 13:20 ` [PATCH 4/5] btrfs: enhance extent_io_tree error reports David Sterba
2023-11-21 13:20 ` [PATCH 5/5] btrfs: always set extent_io_tree::inode and drop fs_info David Sterba
2023-11-21 14:19 ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231121141958.GB1667963@perftesting \
    --to=josef@toxicpanda.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox