From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="BC4Jt2OX"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="P6ZGPHQE" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72EDAD76 for ; Tue, 21 Nov 2023 10:16:02 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D75CD218EB; Tue, 21 Nov 2023 18:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1700590560; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m4hluNgOFgQ4TZB9Mtav9msYneW5b8mfaz7D/NgHU8U=; b=BC4Jt2OXqsb2AIP5FkxZ7Yka+pSiaUFv+DHEZ53wm1k+oumw4E5mrT3pk2+A8qv5uSfzWX X8USsxaZFzEzAKD3irKTgiXb62iJcifjWyRtdpbpbTbt9XqvBc1uOc0BymaxetvBbLhl5D IsreQMKywLN4KLQHoIHUU0DBQ3D8wDU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1700590560; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m4hluNgOFgQ4TZB9Mtav9msYneW5b8mfaz7D/NgHU8U=; b=P6ZGPHQEgyilAuDUy9DmKnpsCHbIteZveaAY8AuoTPc1Jtv8EgwwaZ3dTyk1u0A3nO2LFK vPqBSEkC9hEi2pDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9EE12139FD; Tue, 21 Nov 2023 18:16:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VqhNJeDzXGX6SAAAMHmgww (envelope-from ); Tue, 21 Nov 2023 18:16:00 +0000 Date: Tue, 21 Nov 2023 19:08:51 +0100 From: David Sterba To: Filipe Manana Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 7/8] btrfs: use a dedicated data structure for chunk maps Message-ID: <20231121180851.GT11264@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <777320fd09dfc68a89180723bf5d7368dab06299.1700573314.git.fdmanana@suse.com> <20231121151933.GR11264@twin.jikos.cz> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.05 X-Spamd-Result: default: False [-1.05 / 50.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.30)[dsterba@suse.cz]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_ADDR_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.05)[60.05%] On Tue, Nov 21, 2023 at 04:50:07PM +0000, Filipe Manana wrote: > On Tue, Nov 21, 2023 at 3:26 PM David Sterba wrote: > > On Tue, Nov 21, 2023 at 01:38:38PM +0000, fdmanana@kernel.org wrote: > > > From: Filipe Manana > > > fs/btrfs/disk-io.c | 7 +- > > > fs/btrfs/extent_map.c | 46 --- > > > fs/btrfs/extent_map.h | 4 - > > > fs/btrfs/fs.h | 3 +- > > > fs/btrfs/inode.c | 25 +- > > > fs/btrfs/raid56.h | 2 +- > > > fs/btrfs/scrub.c | 39 +-- > > > fs/btrfs/tests/btrfs-tests.c | 3 +- > > > fs/btrfs/tests/btrfs-tests.h | 1 + > > > fs/btrfs/tests/extent-map-tests.c | 40 +-- > > > fs/btrfs/volumes.c | 540 ++++++++++++++++++------------ > > > fs/btrfs/volumes.h | 45 ++- > > > fs/btrfs/zoned.c | 24 +- > > > > I see a lot of errors when compiling zoned.c, there are still map_lookup > > structures. Do you have the zoned mode config option enabled? > > It misses this hunk: https://pastebin.com/raw/mr1KMZ8N > > Do you want me to send a v2, or do you prefer to fix it up? Simple enough to apply, no need to resend, thanks.