From: David Sterba <dsterba@suse.cz>
To: Filipe Manana <fdmanana@kernel.org>
Cc: David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix 64bit compat send ioctl arguments not initializing version member
Date: Fri, 24 Nov 2023 15:16:49 +0100 [thread overview]
Message-ID: <20231124141648.GA18929@twin.jikos.cz> (raw)
In-Reply-To: <CAL3q7H6C=FJL9cX2-uVo1AhnNAmMOGfFMkTEzHekL5OeW0OAXQ@mail.gmail.com>
On Fri, Nov 24, 2023 at 12:16:55AM +0000, Filipe Manana wrote:
> On Fri, Nov 24, 2023 at 12:08 AM David Sterba <dsterba@suse.com> wrote:
> >
> > When the send protocol versioning was added in 5.16 e77fbf990316
> > ("btrfs: send: prepare for v2 protocol"), the 32/64bit compat code was
> > not updated (added by 2351f431f727 ("btrfs: fix send ioctl on 32bit with
> > 64bit kernel")), missing the version struct member. The compat code is
> > probably rarely used, nobody reported any bugs.
> >
> > Found by tool https://github.com/jirislaby/clang-struct .
> >
> > Fixes: 2351f431f727 ("btrfs: fix send ioctl on 32bit with 64bit kernel")
>
> So this is not the correct commit, you copy-pasted the wrong one from
> the change log above, it should be:
>
> e77fbf990316 ("btrfs: send: prepare for v2 protocol")
Of course, fixed, thanks.
prev parent reply other threads:[~2023-11-24 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 0:00 [PATCH] btrfs: fix 64bit compat send ioctl arguments not initializing version member David Sterba
2023-11-24 0:16 ` Filipe Manana
2023-11-24 14:16 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124141648.GA18929@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox