From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: l@damenly.org, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs-progs: tune: add fsck runs before and after a full conversion
Date: Tue, 5 Dec 2023 17:46:36 +0100 [thread overview]
Message-ID: <20231205164636.GL2751@twin.jikos.cz> (raw)
In-Reply-To: <e051f2dd-dbd6-4e3f-b828-a66a991ed4c2@gmx.com>
On Mon, Dec 04, 2023 at 08:52:15PM +1030, Qu Wenruo wrote:
> > And maybe an option to skip check? People who want to convert to BG tree
> > usually have large filesystems, then the original check can be killed
> > because of OOM...
>
> I don't want to allow it to be skipped. Maybe I can add some logic to go
> lowmem mode depending on the filesystem size.
We have power users who know what they're doing and no way to skip the
check is considered a usability bug. The check can fail for reasons that
may not be due to detected problems but due to lack of memory. The
heuristic regarding lowmem or original mode does not sound like a good
idea to me, it seems too unreliable.
> Just don't want to risk any possible corruption.
Instead of forcing the check in all cases, by default it can skip the
conversion and print a warning with and recommendation to run check.
With an option to override it it would start right away.
next prev parent reply other threads:[~2023-12-05 16:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 6:56 [PATCH 0/3] btrfs-progs: tune: run "btrfs check" before and after full fs conversion Qu Wenruo
2023-12-04 6:56 ` [PATCH 1/3] btrfs-progs: check: remove inode cache clearing functionality Qu Wenruo
2023-12-05 16:47 ` David Sterba
2023-12-04 6:56 ` [PATCH 2/3] btrfs-progs: check: export a dedicated btrfs_check() function Qu Wenruo
2023-12-04 6:56 ` [PATCH 3/3] btrfs-progs: tune: add fsck runs before and after a full conversion Qu Wenruo
2023-12-04 9:44 ` Su Yue
2023-12-04 10:11 ` l
2023-12-04 10:22 ` Qu Wenruo
2023-12-05 16:46 ` David Sterba [this message]
2023-12-05 21:33 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205164636.GL2751@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=l@damenly.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox