public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 0/2] btrfs: migrate extent_buffer::pages[] to folio and more cleanups
Date: Thu, 7 Dec 2023 13:42:35 +0100	[thread overview]
Message-ID: <20231207124235.GV2751@twin.jikos.cz> (raw)
In-Reply-To: <cover.1701902977.git.wqu@suse.com>

On Thu, Dec 07, 2023 at 09:39:26AM +1030, Qu Wenruo wrote:
> [CHANGELOG]
> v2:
> - Add a new patch to do more cleanups for metadata page pointers usage
> 
> v3:
> - Fix a bug in alloc_eb_folio_array() which accesses uninitialized stack
>   It turns out that I have CONFIG_INIT_STACK_ALL_ZERO, which prevents me
>   from exposing the bug. Now changed to CONFIG_INIT_STACK_ALL_PATTERN.

Seems to be fixed, thanks. I had CONFIG_INIT_STACK_NONE=y so it got
caught due to random data on the stack but with
CONFIG_INIT_STACK_ALL_PATTERN the pattern makes it clear that it's due
to that.

Added to misc-next, thanks.

      parent reply	other threads:[~2023-12-07 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 23:09 [PATCH v3 0/2] btrfs: migrate extent_buffer::pages[] to folio and more cleanups Qu Wenruo
2023-12-06 23:09 ` [PATCH v3 1/2] btrfs: migrate extent_buffer::pages[] to folio Qu Wenruo
2023-12-06 23:09 ` [PATCH v3 2/2] btrfs: cleanup metadata page pointer usage Qu Wenruo
2023-12-07 13:43   ` David Sterba
2023-12-07 12:42 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231207124235.GV2751@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox