From: David Disseldorp <ddiss@suse.de>
To: David Sterba <dsterba@suse.cz>
Cc: linux-btrfs@vger.kernel.org, Qu Wenruo <wqu@suse.com>,
David Disseldorp <ddiss@suse.de>
Subject: [PATCH] btrfs: validate scrub_speed_max sysfs string
Date: Fri, 8 Dec 2023 11:41:56 +1100 [thread overview]
Message-ID: <20231208004156.9612-1-ddiss@suse.de> (raw)
In-Reply-To: <20231207135522.GX2751@twin.jikos.cz>
Fail the sysfs I/O on any trailing non-space characters.
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
fs/btrfs/sysfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index e6b51fb3ddc1e..4c4642ef7c5f0 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -1783,6 +1783,9 @@ static ssize_t btrfs_devinfo_scrub_speed_max_store(struct kobject *kobj,
unsigned long long limit;
limit = memparse(buf, &endptr);
+ endptr = skip_spaces(endptr);
+ if (*endptr != 0)
+ return -EINVAL;
WRITE_ONCE(device->scrub_speed_max, limit);
return len;
}
--
2.35.3
next prev parent reply other threads:[~2023-12-08 0:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 11:13 [PATCH] btrfs: drop unused memparse() parameter David Disseldorp
2023-12-05 12:48 ` Johannes Thumshirn
2023-12-05 14:22 ` David Sterba
2023-12-06 0:21 ` David Disseldorp
2023-12-06 18:53 ` David Sterba
2023-12-06 23:52 ` David Disseldorp
2023-12-07 13:55 ` David Sterba
2023-12-08 0:41 ` David Disseldorp [this message]
2023-12-11 3:18 ` [PATCH] btrfs: validate scrub_speed_max sysfs string Qu Wenruo
2023-12-11 3:56 ` David Disseldorp
2023-12-13 22:50 ` David Sterba
2023-12-13 22:52 ` David Sterba
2023-12-07 2:31 ` [PATCH] btrfs: drop unused memparse() parameter Qu Wenruo
2023-12-07 12:15 ` David Sterba
2023-12-07 19:56 ` Qu Wenruo
2023-12-13 23:15 ` David Sterba
2023-12-13 23:46 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208004156.9612-1-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox