Re: [PATCH] fstests: btrfs: use proper filter for subvolume deletion

David Disseldorp
2023-12-22T07:30:59Z

On Fri, 22 Dec 2023 06:02:41 +0000, Naohiro Aota wrote:

> > > # Import common functions.
> > > . ./common/filter
> > > +. ./common/filter.btrfs
> >
> > common/filter.btrfs sources common/filter, so you can replace these.
>
> Oh, I didn't notice that. But, there are many test cases importing
> both. Maybe, it's good to express direct dependency (e.g, for
> _filter_scratch) explicitly? Or, they should be fixed as well?

I don't have a strong preference either way. I don't see any ordering
dependencies, so separate imports would also work.

Cheers, David