Re: [PATCH 2/3] f2fs: move release of block devices to after kill_block_super()

Eric Biggers
2023-12-27T04:47:06Z

On Tue, Dec 12, 2023 at 08:00:17PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Call destroy_device_list() and free the f2fs_sb_info from
> kill_f2fs_super(), after the call to kill_block_super(). This is
> necessary to order it after the call to fscrypt_destroy_keyring() once
> generic_shutdown_super() starts calling fscrypt_destroy_keyring() just
> after calling ->put_super. This is because fscrypt_destroy_keyring()
> may call into f2fs_get_devices() via the fscrypt_operations.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> fs/f2fs/super.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)

Jaegeuk and Chao, when you have a chance can you review or ack this? I'm
thinking of taking patches 2-3 of this series through the fscrypt tree for 6.8.

- Eric