Re: [PATCH v2] btrfs-progs: convert-ext2: insert a dummy inode item before inode ref

[David Sterba <dsterba@suse.cz>]

On Tue, Jan 16, 2024 at 07:47:38PM +0100, David Sterba wrote:
> On Sat, Jan 13, 2024 at 07:07:06PM +1030, Qu Wenruo wrote:
> > -static inline u32 btrfs_type_to_imode(u8 type)
> > -{
> > -	static u32 imode_by_btrfs_type[] = {
> > -		[BTRFS_FT_REG_FILE]	= S_IFREG,
> > -		[BTRFS_FT_DIR]		= S_IFDIR,
> > -		[BTRFS_FT_CHRDEV]	= S_IFCHR,
> > -		[BTRFS_FT_BLKDEV]	= S_IFBLK,
> > -		[BTRFS_FT_FIFO]		= S_IFIFO,
> > -		[BTRFS_FT_SOCK]		= S_IFSOCK,
> > -		[BTRFS_FT_SYMLINK]	= S_IFLNK,
> > -	};
> > -
> > -	return imode_by_btrfs_type[(type)];
> > -}
> 
> Why did you move this helper to utils.h? Here it's available for
> anything that needs it. Mkfs and convert share some code, no style
> problem to cross include from each other. Also moving it to utils.h is
> going the opposite way, it's a header that's a default if there's no
> better place. Lot of code has been factored out of it.

Ok so I confused mkfs and check, the header is from check/ and is not
clean for inclusion in convert due to task_ctx conflict. So I'll keep it
but noted for a future cleanup.