From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] Block size helper cleanups
Date: Thu, 18 Jan 2024 23:29:41 +0100 [thread overview]
Message-ID: <20240118222941.GQ31555@twin.jikos.cz> (raw)
In-Reply-To: <99eb80c4-4434-4d97-87b8-c4f4e7c3c5cd@oracle.com>
On Thu, Jan 18, 2024 at 02:16:11PM +0800, Anand Jain wrote:
>
>
>
> Sorry for the late comments. Looks good
>
> Reviewed-by: Anand Jain <anand.jain@oracle.com>
>
>
>
> just one nit:
> You may also bring the following repetitive code into a new
> helper function as it is used once in init_mount_fs_info()
> and again in open_ctree():
I don't think we need the helper here, it's for the one-time
initializations, unlikely to be needed anywhere else that would justify
it.
prev parent reply other threads:[~2024-01-18 22:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 17:10 [PATCH 0/2] Block size helper cleanups David Sterba
2024-01-17 17:10 ` [PATCH 1/2] btrfs: replace sb::s_blocksize by fs_info::sectorsize David Sterba
2024-01-17 17:10 ` [PATCH 2/2] btrfs: replace i_blocksize " David Sterba
2024-01-17 18:53 ` [PATCH 0/2] Block size helper cleanups Josef Bacik
2024-01-18 6:16 ` Anand Jain
2024-01-18 22:29 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118222941.GQ31555@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox