[PATCH 16/20] btrfs: change BUG_ON to assertion in reset_balance_state()

David Sterba
2024-01-24T21:19:06Z

The balance state machine is complex so it's good to verify the
assumptions in helpers, however reset_balance_state() is used
at the end of balance and fs_info::balance_ctl is properly set up before
and protected by the exclusive op ownership in btrfs_balance().

Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/btrfs/volumes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 6aae92e4b424..59fc6ab18fef 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -3634,7 +3634,7 @@ static void reset_balance_state(struct btrfs_fs_info *fs_info)
struct btrfs_balance_control *bctl = fs_info->balance_ctl;
int ret;

- BUG_ON(!fs_info->balance_ctl);
+ ASSERT(fs_info->balance_ctl);

spin_lock(&fs_info->balance_lock);
fs_info->balance_ctl = NULL;
--
2.42.1