From: Eugeniu Rosca <erosca@de.adit-jv.com>
To: Filipe Manana <fdmanana@kernel.org>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
<linux-btrfs@vger.kernel.org>, <Maksim.Paimushkin@se.bosch.com>,
<Matthias.Thomae@de.bosch.com>, <Sebastian.Unger@bosch.com>,
<Dirk.Behme@de.bosch.com>, <Eugeniu.Rosca@bosch.com>,
<wqu@suse.com>, <dsterba@suse.com>, <stable@vger.kernel.org>,
Filipe Manana <fdmanana@suse.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>
Subject: Re: [PATCH 0/4 for 5.15 stable] btrfs: some directory fixes for stable 5.15
Date: Mon, 29 Jan 2024 14:39:31 +0100 [thread overview]
Message-ID: <20240129133931.GA2758728@lxhi-087> (raw)
In-Reply-To: <CAL3q7H5obj92hJ3qc8qUw_9aiMAwiF+RMZhu0M4dGT+hhp6Qsg@mail.gmail.com>
Hello Filipe,
On Sat, Jan 27, 2024 at 06:02:55PM +0000, Filipe Manana wrote:
> On Fri, Jan 26, 2024 at 6:55 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote:
[..]
> > PS: Could you help me out how (and if at all possible) to preserve the
> > Author date of the original patch when downloading and applying the
> > 'raw' file provided by https:// lore.kernel.org/
>
> If I understand you correctly, you applied the diff of patches
> directly with the "patch" command.
Nope. I download the 'raw' patch [0] (assumed to be in mbox format?),
then apply it via 'git am'. This workflow should preserve such patch
metadata like commit description, Author's name/date, etc.
> To get kernel patches and apply them easily, use the b4 tool available at:
>
> git://git.kernel.org/pub/scm/utils/b4/b4.git
Thanks for sharing. This reminds me of patchwork/pwclient.
I've reapplied the patches using 'b4' and Author's Date of the stable
commits is still altered compared to the vanilla/mainline commits.
For example:
- Author's date of vanilla [2]: 2023-08-13 12:34:08 +0100
- Author's date of stable [1]: 2024-01-25 11:59:35 +0000
This likely means that the Author's date is amended during
porting/cherry-picking. Of course, this is not a major issue,
but some of us may assume that most of patch metadata (including
Author's date) is preserved on backporting (as best practice).
PS: We can likely skip it, since a number of other patches seem to
alter the Author's date on 5.15 stable tree (~600 out of 21k+ commits).
[1] https:// lore.kernel.org/stable/f1e33797054fcea8b61d88878e67b8c007b5d5f5.1706183427.git.fdmanana@suse.com/raw
[2] https:// git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9b378f6ad48cfa
Thanks,
Eugeniu
next prev parent reply other threads:[~2024-01-29 13:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 11:59 [PATCH 0/4 for 5.15 stable] btrfs: some directory fixes for stable 5.15 fdmanana
2024-01-25 11:59 ` [PATCH 1/4 for 5.15 stable] btrfs: fix infinite directory reads fdmanana
2024-01-26 19:06 ` Eugeniu Rosca
2024-01-25 11:59 ` [PATCH 2/4 for 5.15 stable] btrfs: set last dir index to the current last index when opening dir fdmanana
2024-01-26 19:07 ` Eugeniu Rosca
2024-01-25 11:59 ` [PATCH 3/4 for 5.15 stable] btrfs: refresh dir last index during a rewinddir(3) call fdmanana
2024-01-26 19:08 ` Eugeniu Rosca
2024-01-25 11:59 ` [PATCH 4/4 for 5.15 stable] btrfs: fix race between reading a directory and adding entries to it fdmanana
2024-01-26 19:09 ` Eugeniu Rosca
2024-01-26 18:55 ` [PATCH 0/4 for 5.15 stable] btrfs: some directory fixes for stable 5.15 Eugeniu Rosca
2024-01-27 18:02 ` Filipe Manana
2024-01-29 13:39 ` Eugeniu Rosca [this message]
2024-01-27 1:15 ` Greg KH
2024-01-27 17:58 ` Filipe Manana
2024-01-27 18:18 ` Filipe Manana
2024-01-27 21:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129133931.GA2758728@lxhi-087 \
--to=erosca@de.adit-jv.com \
--cc=Dirk.Behme@de.bosch.com \
--cc=Eugeniu.Rosca@bosch.com \
--cc=Maksim.Paimushkin@se.bosch.com \
--cc=Matthias.Thomae@de.bosch.com \
--cc=Sebastian.Unger@bosch.com \
--cc=dsterba@suse.com \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=roscaeugeniu@gmail.com \
--cc=stable@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox