From: David Sterba <dsterba@suse.cz>
To: Naohiro Aota <Naohiro.Aota@wdc.com>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"wangyugui@e16-tech.com" <wangyugui@e16-tech.com>,
"clm@meta.com" <clm@meta.com>, "hch@lst.de" <hch@lst.de>
Subject: Re: Re: [PATCH v2] btrfs: introduce sync_csum_mode to tweak sync checksum behavior
Date: Thu, 1 Feb 2024 03:11:51 +0100 [thread overview]
Message-ID: <20240201021151.GU31555@suse.cz> (raw)
In-Reply-To: <6ljnyrwminqxmtjmdozivtdgaiymp75xytxxvbgpkznpv3chwa@4v2r3emp5ko7>
On Thu, Feb 01, 2024 at 01:16:40AM +0000, Naohiro Aota wrote:
> On Wed, Jan 31, 2024 at 07:58:43PM +0100, David Sterba wrote:
> > On Wed, Jan 31, 2024 at 02:15:32PM +0000, Johannes Thumshirn wrote:
> > > On 31.01.24 08:15, Naohiro Aota wrote:
> > Yes we use the *_ONCE helpers for values set from sysfs in cases where
> > it's without bad effects to race and change the value in the middle.
> > Here it would only skip one checksum offload/sync. It's not really a
> > guard but a note that there's something special about the value.
>
> Sure. I'll use it just in case.
>
> Maybe, we want to convert fs_devices->read_policy as well, to prepare for
> the feature we have more read policies implemented?
Yes indeed, good catch.
next prev parent reply other threads:[~2024-02-01 2:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 7:13 [PATCH v2] btrfs: introduce sync_csum_mode to tweak sync checksum behavior Naohiro Aota
2024-01-31 14:15 ` Johannes Thumshirn
2024-01-31 18:58 ` David Sterba
2024-02-01 1:16 ` Naohiro Aota
2024-02-01 2:11 ` David Sterba [this message]
2024-01-31 19:04 ` David Sterba
2024-02-01 1:28 ` Naohiro Aota
2024-02-01 2:14 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201021151.GU31555@suse.cz \
--to=dsterba@suse.cz \
--cc=Johannes.Thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=clm@meta.com \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox