From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>,
Qu Wenruo <quwenruo.btrfs@gmx.com>,
Naohiro Aota <naohiro.aota@wdc.com>, HAN Yuwei <hrx@bupt.moe>
Subject: Re: [PATCH] btrfs: zoned: don't skip block group profile checks on conv zones
Date: Wed, 14 Feb 2024 19:11:39 +0100 [thread overview]
Message-ID: <20240214181139.GS355@twin.jikos.cz> (raw)
In-Reply-To: <0cd08a6b0f5285498811504d3713ced3afe3b8d2.1707812175.git.johannes.thumshirn@wdc.com>
On Tue, Feb 13, 2024 at 12:16:15AM -0800, Johannes Thumshirn wrote:
> On a zoned filesystem with conventional zones, we're skipping the block
> group profile checks for the conventional zones.
>
> This allows converting a zoned filesystem's data block groups to RAID when
> all of the zones backing the chunk are on conventional zones. But this
> will lead to problems, once we're trying to allocate chunks backed by
> sequential zones.
>
> So also check for conventional zones when loading a block group's profile
> on them.
>
> Reported-by: HAN Yuwei <hrx@bupt.moe>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Please add link to the report (as Link: tag), I think it is interesting
how the root cause was discovered.
next prev parent reply other threads:[~2024-02-14 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 8:16 [PATCH] btrfs: zoned: don't skip block group profile checks on conv zones Johannes Thumshirn
2024-02-13 21:58 ` Boris Burkov
2024-02-14 15:59 ` Naohiro Aota
2024-02-14 18:11 ` David Sterba [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-09 10:46 Johannes Thumshirn
2024-02-09 14:29 ` Naohiro Aota
2024-02-12 9:48 ` Johannes Thumshirn
2024-02-12 1:59 ` Damien Le Moal
2024-02-12 4:00 ` HAN Yuwei
2024-02-12 11:26 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240214181139.GS355@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=hrx@bupt.moe \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox