From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: subvolume: output the prompt line only when the ioctl succeeded
Date: Fri, 1 Mar 2024 13:56:31 +0100 [thread overview]
Message-ID: <20240301125631.GK2604@twin.jikos.cz> (raw)
In-Reply-To: <7d1ce9fe71dac086bb0037b517e2d932bb2a5b04.1709007014.git.wqu@suse.com>
On Tue, Feb 27, 2024 at 02:41:16PM +1030, Qu Wenruo wrote:
> [BUG]
> With the latest kernel patch to reject invalid qgroupids in
> btrfs_qgroup_inherit structure, "btrfs subvolume create" or "btrfs
> subvolume snapshot" can lead to the following output:
>
> # mkfs.btrfs -O quota -f $dev
> # mount $dev $mnt
> # btrfs subvolume create -i 2/0 $mnt/subv1
> Create subvolume '/mnt/btrfs/subv1'
> ERROR: cannot create subvolume: No such file or directory
>
> The "btrfs subvolume" command output the first line, seemingly to
> indicate a successful subvolume creation, then followed by an error
> message.
>
> This can be a little confusing on whether if the subvolume is created or
> not.
>
> [FIX]
> Fix the output by only outputting the regular line if the ioctl
> succeeded.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Added to devel, thanks.
next prev parent reply other threads:[~2024-03-01 13:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 4:11 [PATCH] btrfs-progs: subvolume: output the prompt line only when the ioctl succeeded Qu Wenruo
2024-02-27 4:59 ` HAN Yuwei
2024-02-27 5:31 ` Qu Wenruo
2024-03-01 12:56 ` David Sterba [this message]
2024-03-26 20:23 ` Boris Burkov
2024-03-26 20:27 ` Qu Wenruo
2024-03-26 20:30 ` Qu Wenruo
2024-03-26 20:34 ` Boris Burkov
2024-03-26 22:44 ` David Sterba
2024-03-26 20:33 ` Boris Burkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301125631.GK2604@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox