Re: [PATCH 01/29] btrfs: btrfs_cleanup_fs_roots rename ret to ret2 and err to ret

Josef Bacik
2024-03-19T17:38:48Z

On Tue, Mar 19, 2024 at 08:25:09PM +0530, Anand Jain wrote:
> Since err represents the function return value, rename it as ret,
> and rename the original ret, which serves as a helper return value,
> to ret2.
>

I hate to be that guy right out the gate, but since we're just using ret2 as the
return value of radix_tree_gang_lookup, and that's just the number of fs_roots,
lets instead a variation of

unsigned int nr_found = 0;
unsigned int nr = 0;
unsigned int found = 0;

since we know this isn't just a temporary ret value, it actually corresponds to
something. Thanks,

Josef