Re: [PATCH 19/29] btrfs: mark_garbage_root rename err to ret2

Josef Bacik
2024-03-19T18:07:51Z

On Tue, Mar 19, 2024 at 08:25:27PM +0530, Anand Jain wrote:
> In this function, the variable err is used as the second return value. If
> it is not zero, rename it to ret2.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>

This is fine but terrible, a good follow up cleanup would be to make
btrfs_end_transaction() a void and remove the random places we check for an
error. We don't really need it to tell use we have EROFS, we'll get it in some
other operation down the line if we didn't get it somewhere in here. Thanks,

Josef