From: David Disseldorp <ddiss@suse.de>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC] btrfs: reflink: disable cross-subvolume clone/dedupe for simple quota
Date: Fri, 22 Mar 2024 00:25:44 +1100 [thread overview]
Message-ID: <20240322002544.6904f696@echidna> (raw)
In-Reply-To: <74730c411b0fd87484c8d894878c5cd8bac1d434.1710992258.git.wqu@suse.com>
On Thu, 21 Mar 2024 14:09:38 +1030, Qu Wenruo wrote:
...
> [REASON FOR RFC]
> I'm not sure how important the cross-subvolume clone functionality is in
> real-world.
>
> But considering squota is mostly designed for container usage, in that
> case disabling cross-subvolume clone should be completely fine.
I think copy_file_range() is reasonably common nowadays, and this would
impact such workloads. I don't find the creator-subvol-pays simple quota
behaviour too confusing, so would vote too keep things as is.
Cheers, David
next prev parent reply other threads:[~2024-03-21 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 3:39 [PATCH RFC] btrfs: reflink: disable cross-subvolume clone/dedupe for simple quota Qu Wenruo
2024-03-21 7:34 ` Roman Mamedov
2024-03-21 13:25 ` David Disseldorp [this message]
2024-03-21 20:17 ` Qu Wenruo
2024-03-21 18:51 ` Josef Bacik
2024-03-21 19:08 ` Boris Burkov
2024-03-21 23:59 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322002544.6904f696@echidna \
--to=ddiss@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox