Re: [PATCH 1/6] btrfs-progs: remove unused header for tune/main.c

[David Sterba <dsterba@suse.cz>]

On Tue, Mar 26, 2024 at 10:52:41AM +1030, Qu Wenruo wrote:
> My clangd LSP server reports warning that "common/parse-utils.h" is not
> utilized at all.

Please be careful about removing headers, the LSP depends on the
build flags and reports symbols or headers only for the last configured
state.

In this case removing parse-utils.h causes compilation error in
experimental mode because of

287 #if EXPERIMENTAL
288                 case GETOPT_VAL_CSUM:
289                         btrfs_warn_experimental(
290                                 "Switching checksums is experimental, do not use for valuable data!");
291                         ctree_flags |= OPEN_CTREE_SKIP_CSUM_CHECK;
292                         csum_type = parse_csum_type(optarg);
                                        ^^^^^^^^^^^^^^^^^^^^^^^

293                         btrfstune_cmd_groups[CSUM_CHANGE] = true;
294                         break;
295 #endif

Some build checks or targets could be missing so we'd lack coverage and
early warnings during development, this needs to be fixed.

Builds that change LSP state (and combinations):

- make box
- make static box.static
- various D= values and modes
- configure --experimental
- possibly different includes for glibc and musl defining a symbol
  indirectly