From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs-progs: revert `btrfs subvolume delete --delete-qgroup` option
Date: Mon, 29 Apr 2024 19:29:57 +0200 [thread overview]
Message-ID: <20240429172957.GJ2585@twin.jikos.cz> (raw)
In-Reply-To: <cover.1714082499.git.wqu@suse.com>
On Fri, Apr 26, 2024 at 07:35:51AM +0930, Qu Wenruo wrote:
> The introduction of `btrfs subvolume delete --delete-qgroup` would not
> work for a lot of real world cases.
>
> This would leads to unnecessary errors, and can be very confusing for
> end users.
>
> Furthermore the new options do not take the lifespan of a subvolume into
> consideration or the possible conflicts with other qgroup features.
>
> Although it's already too late, we should revert it to prevent further
> confusion and damage.
The options have been there since 6.6.3 so it's about 2 full releases
but it better be removed now.
> Qu Wenruo (2):
> Revert "btrfs-progs: subvol delete: add options to delete the qgroup"
> btrfs: misc-tests: remove the subvol-delete-qgroup test case
Added to devel, thanks.
prev parent reply other threads:[~2024-04-29 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 22:05 [PATCH 0/2] btrfs-progs: revert `btrfs subvolume delete --delete-qgroup` option Qu Wenruo
2024-04-25 22:05 ` [PATCH 1/2] Revert "btrfs-progs: subvol delete: add options to delete the qgroup" Qu Wenruo
2024-04-25 22:05 ` [PATCH 2/2] btrfs: misc-tests: remove the subvol-delete-qgroup test case Qu Wenruo
2024-04-29 17:48 ` David Sterba
2024-04-29 17:29 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429172957.GJ2585@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox