From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs: basic header cleanups
Date: Tue, 28 May 2024 17:33:45 +0200 [thread overview]
Message-ID: <20240528153345.GD8631@twin.jikos.cz> (raw)
In-Reply-To: <cover.1716874214.git.wqu@suse.com>
On Tue, May 28, 2024 at 03:03:46PM +0930, Qu Wenruo wrote:
> While reading headers, clangd would do a lot of extra checks, from the
> very basic like including the header itself, to missing type definition
> inside the header's include chain.
>
> There are 2 very basic fixes can be done immediately:
>
> - Do not do recursive include
>
> - Do not include rwlock_types.h
> As it already mentioned to include spinlock_types.h instead.
>
> Qu Wenruo (2):
> btrfs: cleanup recursive include of the same header
> btrfs: do not directly rwlock_types.h
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2024-05-28 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 5:33 [PATCH 0/2] btrfs: basic header cleanups Qu Wenruo
2024-05-28 5:33 ` [PATCH 1/2] btrfs: cleanup recursive include of the same header Qu Wenruo
2024-05-28 10:20 ` Filipe Manana
2024-05-28 21:10 ` David Sterba
2024-05-28 5:33 ` [PATCH 2/2] btrfs: do not directly rwlock_types.h Qu Wenruo
2024-05-28 10:22 ` Filipe Manana
2024-05-28 15:33 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528153345.GD8631@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox