Re: [PATCH v4 05/10] btrfs-progs: mkfs: align byte_count with sectorsize and zone size

[David Sterba <dsterba@suse.cz>]

On Wed, May 29, 2024 at 05:15:37PM +0930, Qu Wenruo wrote:
> 
> 
> 在 2024/5/29 16:43, Naohiro Aota 写道:
> > While "byte_count" is eventually rounded down to sectorsize at make_btrfs()
> > or btrfs_add_to_fs_id(), it would be better round it down first and do the
> > size checks not to confuse the things.
> >
> > Also, on a zoned device, creating a btrfs whose size is not aligned to the
> > zone boundary can be confusing. Round it down further to the zone boundary.
> >
> > The size calculation with a source directory is also tweaked to be aligned.
> > device_get_partition_size_fd_stat() must be aligned down not to exceed the
> > device size. And, btrfs_mkfs_size_dir() should have return sectorsize aligned
> > size. So, add an UASSERT for it.
> >
> > Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> 
> Reviewed-by: Qu Wenruo <wqu@suse.com>
> 
> To David, since I have the write permission to btrfs-progs and reviewed
> the series, can I push it to devel branch now?

OK, go on. I'm done for now with changes to fix the LE/BE and unaligned
access. For future it would be better if you create a pull request and
mark it that you want to merge it yourself, I could miss it in replies
to patches in the middle of a series.