Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: error out immediately if an unknown backref type is hit
Date: Tue, 4 Jun 2024 11:58:51 -0400	[thread overview]
Message-ID: <20240604155851.GD3413@localhost.localdomain> (raw)
In-Reply-To: <a8cb7544a9369a309212cf648facc4cf51199616.1717479367.git.wqu@suse.com>

On Tue, Jun 04, 2024 at 03:06:22PM +0930, Qu Wenruo wrote:
> There is a bug report that for fuzzed image
> bko-155621-bad-block-group-offset.raw, "btrfs check --mode=lowmem
> --repair" would lead to a deadloop.
> 
> Unlike original mode, lowmem mode relies on the backref walk to properly
> go through each root, but unfortunately inside __add_inline_refs() we
> doesn't handle unknown backref types correctly, causing it never moving
> forward thus deadloop.
> 
> Fix it by erroring out to prevent deadloop.
> 
> Issue: #788
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

      reply	other threads:[~2024-06-04 15:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04  5:36 [PATCH] btrfs-progs: error out immediately if an unknown backref type is hit Qu Wenruo
2024-06-04 15:58 ` Josef Bacik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240604155851.GD3413@localhost.localdomain \
    --to=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox