From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/4] btrfs: remove unused Opt enums
Date: Wed, 12 Jun 2024 21:31:59 +0200 [thread overview]
Message-ID: <20240612193159.GJ18508@twin.jikos.cz> (raw)
In-Reply-To: <f97d2899f6e701257b3304d553af79d39ea8e2f3.1718082585.git.wqu@suse.com>
On Tue, Jun 11, 2024 at 02:51:35PM +0930, Qu Wenruo wrote:
> The following three Opt_* enums are not utilized at all:
>
> - Opt_ignorebadroots
> - Opt_ignoredatacsums
> - Opt_rescue_all
They've been duplicated in the new mount API rewrite and the currently
used enums are in Opt_rescue_* group, like Opt_rescue_parameter_all.
> All those handling are inside "rescue=" mount option groups, and there
> is no corresponding token for them, so we can safely remove them.
Yes.
next prev parent reply other threads:[~2024-06-12 19:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 5:21 [PATCH 0/4] btrfs: rescue= mount options enhancement to support interrupted csum conversion Qu Wenruo
2024-06-11 5:21 ` [PATCH 1/4] btrfs: remove unused Opt enums Qu Wenruo
2024-06-12 19:31 ` David Sterba [this message]
2024-06-11 5:21 ` [PATCH 2/4] btrfs: output the unrecognized super flags as hex Qu Wenruo
2024-06-11 5:21 ` [PATCH 3/4] btrfs: introduce new "rescue=ignoremetacsums" mount option Qu Wenruo
2024-06-12 19:38 ` David Sterba
2024-06-13 21:28 ` Qu Wenruo
2024-06-16 18:17 ` David Sterba
2024-06-16 21:24 ` Qu Wenruo
2024-06-11 5:21 ` [PATCH 4/4] btrfs: introduce new "rescue=ignoresuperflags" " Qu Wenruo
2024-06-12 19:42 ` David Sterba
2024-06-13 21:46 ` Qu Wenruo
2024-06-11 16:43 ` [PATCH 0/4] btrfs: rescue= mount options enhancement to support interrupted csum conversion Josef Bacik
2024-06-13 21:23 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612193159.GJ18508@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox