Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: David Sterba <dsterba@suse.cz>
Cc: Johannes Thumshirn <jth@kernel.org>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH] btrfs-progs: remove raid stripe encoding
Date: Mon, 24 Jun 2024 19:09:51 +0200	[thread overview]
Message-ID: <20240624170951.GT25756@twin.jikos.cz> (raw)
In-Reply-To: <20240624170715.GS25756@twin.jikos.cz>

On Mon, Jun 24, 2024 at 07:07:15PM +0200, David Sterba wrote:
> On Thu, Jun 20, 2024 at 09:54:55AM +0200, Johannes Thumshirn wrote:
> > From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> > 
> > Remove the not needed encoding and reserved fields in struct
> > raid_stripe_extent.
> > 
> > This saves 8 bytes per stripe extent.
> > 
> > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> > ---
> >  kernel-shared/accessors.h       |  3 ---
> >  kernel-shared/print-tree.c      | 33 +--------------------------------
> >  kernel-shared/uapi/btrfs_tree.h | 14 +-------------
> >  3 files changed, 2 insertions(+), 48 deletions(-)
> 
> This fails to compiler because the tree-checker.c code still references
> the removed functions:
> 
> kernel-shared/tree-checker.c: In function ‘check_raid_stripe_extent’:
> kernel-shared/tree-checker.c:1740:17: warning: implicit declaration of function ‘btrfs_stripe_extent_encoding’; did you mean ‘btrfs_file_extent_end’? [-Wimplicit-function-declaration]
>  1740 |         switch (btrfs_stripe_extent_encoding(leaf, stripe_extent)) {
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixed in devel.

  reply	other threads:[~2024-06-24 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20  7:54 [PATCH] btrfs-progs: remove raid stripe encoding Johannes Thumshirn
2024-06-24 17:07 ` David Sterba
2024-06-24 17:09   ` David Sterba [this message]
2024-06-24 17:30 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624170951.GT25756@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=dsterba@suse.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=jth@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox