Re: [PATCH] btrfs: move the direct IO code into its own file

[David Sterba <dsterba@suse.cz>]

On Tue, Jun 25, 2024 at 04:16:50PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> The direct IO code is over a thousand lines and it's currently spread
> between file.c and inode.c, which makes it not easy to locate some parts
> of it sometimes. Also inode.c is about 11 thousand lines and file.c about
> 4 thousand lines, both too big. So move all the direct IO code into a
> dedicated file, so that it's easy to locate all its code and reduce the
> sizes of inode.c and file.c.
> 
> This is a pure move of code without any other changes except export a
> a couple functions from inode.c (get_extent_allocation_hint() and
> create_io_em()) because they are used in inode.c and the new direct-io.c
> file, and a couple functions from file.c (btrfs_buffered_write() and
> btrfs_write_check()) because they are used both in file.c and in the new
> direct-io.c file.
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Makes sense. The only thing that comes to mind is merge target and
potential collisions with other patches but I am not aware of anything.
As usual with the big code movements the future fixes will have to be
manually backported.

I have only paged through the changes and not reviewed it, bug feel free
to add it to for-next.