Re: [PATCH] btrfs: support STATX_DIOALIGN for statx

[kernel test robot <lkp@intel.com>]

Hi Hongbo,

kernel test robot noticed the following build errors:

[auto build test ERROR on kdave/for-next]
[also build test ERROR on linus/master v6.10-rc5 next-20240625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hongbo-Li/btrfs-support-STATX_DIOALIGN-for-statx/20240625-141147
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
patch link:    https://lore.kernel.org/r/20240620132000.888494-1-lihongbo22%40huawei.com
patch subject: [PATCH] btrfs: support STATX_DIOALIGN for statx
config: i386-randconfig-015-20240626 (https://download.01.org/0day-ci/archive/20240626/202406260839.lNfzNan4-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240626/202406260839.lNfzNan4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406260839.lNfzNan4-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/btrfs/inode.c: In function 'btrfs_getattr':
   fs/btrfs/inode.c:8561:3: error: unknown type name 'btrfs_fs_info'; use 'struct' keyword to refer to the type
      btrfs_fs_info *fs_info = inode_to_fs_info(inode);
      ^~~~~~~~~~~~~
      struct 
   In file included from fs/btrfs/ctree.h:20:0,
                    from fs/btrfs/inode.c:38:
>> fs/btrfs/fs.h:882:34: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
    #define inode_to_fs_info(_inode) (BTRFS_I(_Generic((_inode),   \
                                     ^
   fs/btrfs/inode.c:8561:28: note: in expansion of macro 'inode_to_fs_info'
      btrfs_fs_info *fs_info = inode_to_fs_info(inode);
                               ^~~~~~~~~~~~~~~~
   fs/btrfs/inode.c:8562:38: error: request for member 'fs_devices' in something not a structure or union
      struct block_device *bdev = fs_info->fs_devices->latest_dev->bdev;
                                         ^~
   In file included from arch/x86/include/asm/atomic.h:5:0,
                    from include/linux/atomic.h:7,
                    from include/crypto/hash.h:11,
                    from fs/btrfs/inode.c:6:
   fs/btrfs/inode.c:8566:11: error: request for member 'sectorsize' in something not a structure or union
       fs_info->sectorsize);
              ^
   include/linux/compiler.h:284:48: note: in definition of macro '__is_constexpr'
     (sizeof(int) == sizeof(*(8 ? ((void *)((long)(x) * 0l)) : (int *)8)))
                                                   ^
   include/linux/minmax.h:169:27: note: in expansion of macro '__careful_cmp'
    #define max_t(type, x, y) __careful_cmp(max, (type)(x), (type)(y))
                              ^~~~~~~~~~~~~
   fs/btrfs/inode.c:8565:25: note: in expansion of macro 'max_t'
      stat->dio_mem_align = max_t(u32, (bdev_dma_alignment(bdev) + 1),
                            ^~~~~
   In file included from include/linux/kernel.h:28:0,
                    from include/linux/cpumask.h:11,
                    from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/spinlock.h:63,
                    from include/linux/swait.h:7,
                    from include/linux/completion.h:12,
                    from include/linux/crypto.h:15,
                    from include/crypto/hash.h:12,
                    from fs/btrfs/inode.c:6:
   fs/btrfs/inode.c:8566:11: error: request for member 'sectorsize' in something not a structure or union
       fs_info->sectorsize);
              ^
   include/linux/minmax.h:46:45: note: in definition of macro '__cmp'
    #define __cmp(op, x, y) ((x) __cmp_op_##op (y) ? (x) : (y))
                                                ^
   include/linux/minmax.h:169:27: note: in expansion of macro '__careful_cmp'
    #define max_t(type, x, y) __careful_cmp(max, (type)(x), (type)(y))
                              ^~~~~~~~~~~~~
   fs/btrfs/inode.c:8565:25: note: in expansion of macro 'max_t'
      stat->dio_mem_align = max_t(u32, (bdev_dma_alignment(bdev) + 1),
                            ^~~~~
   fs/btrfs/inode.c:8566:11: error: request for member 'sectorsize' in something not a structure or union
       fs_info->sectorsize);
              ^
   include/linux/minmax.h:46:57: note: in definition of macro '__cmp'
    #define __cmp(op, x, y) ((x) __cmp_op_##op (y) ? (x) : (y))
                                                            ^
   include/linux/minmax.h:169:27: note: in expansion of macro '__careful_cmp'
    #define max_t(type, x, y) __careful_cmp(max, (type)(x), (type)(y))
                              ^~~~~~~~~~~~~
   fs/btrfs/inode.c:8565:25: note: in expansion of macro 'max_t'
      stat->dio_mem_align = max_t(u32, (bdev_dma_alignment(bdev) + 1),
                            ^~~~~
   fs/btrfs/inode.c:8566:11: error: request for member 'sectorsize' in something not a structure or union
       fs_info->sectorsize);
              ^
   include/linux/minmax.h:50:9: note: in definition of macro '__cmp_once'
     typeof(y) unique_y = (y);   \
            ^
   include/linux/minmax.h:169:27: note: in expansion of macro '__careful_cmp'
    #define max_t(type, x, y) __careful_cmp(max, (type)(x), (type)(y))
                              ^~~~~~~~~~~~~
   fs/btrfs/inode.c:8565:25: note: in expansion of macro 'max_t'
      stat->dio_mem_align = max_t(u32, (bdev_dma_alignment(bdev) + 1),
                            ^~~~~
   fs/btrfs/inode.c:8566:11: error: request for member 'sectorsize' in something not a structure or union
       fs_info->sectorsize);
              ^
   include/linux/minmax.h:50:24: note: in definition of macro '__cmp_once'
     typeof(y) unique_y = (y);   \
                           ^
   include/linux/minmax.h:169:27: note: in expansion of macro '__careful_cmp'
    #define max_t(type, x, y) __careful_cmp(max, (type)(x), (type)(y))
                              ^~~~~~~~~~~~~
   fs/btrfs/inode.c:8565:25: note: in expansion of macro 'max_t'
      stat->dio_mem_align = max_t(u32, (bdev_dma_alignment(bdev) + 1),
                            ^~~~~
   In file included from include/linux/atomic/atomic-instrumented.h:15:0,
                    from include/linux/atomic.h:82,
                    from include/crypto/hash.h:11,
                    from fs/btrfs/inode.c:6:
   fs/btrfs/inode.c:8566:11: error: request for member 'sectorsize' in something not a structure or union
       fs_info->sectorsize);
              ^
   include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
    #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
                                                           ^~~~
   include/linux/minmax.h:51:2: note: in expansion of macro 'static_assert'
     static_assert(__types_ok(x, y),   \
     ^~~~~~~~~~~~~
   include/linux/minmax.h:31:24: note: in expansion of macro '__is_constexpr'
     __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \
                           ^~~~~~~~~~~~~~
   include/linux/minmax.h:31:39: note: in expansion of macro 'is_signed_type'
     __builtin_choose_expr(__is_constexpr(is_signed_type(typeof(x))), \


vim +882 fs/btrfs/fs.h

b33d2e535f9b2a David Sterba 2023-09-14  881  
41044b41ad2c8c David Sterba 2023-09-14 @882  #define inode_to_fs_info(_inode) (BTRFS_I(_Generic((_inode),			\
41044b41ad2c8c David Sterba 2023-09-14  883  					   struct inode *: (_inode)))->root->fs_info)
41044b41ad2c8c David Sterba 2023-09-14  884  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki